[kwinrules] Properly setting the value of the activity combo box
ClosedPublic

Authored by ivan on Sep 24 2016, 8:40 AM.

Details

Summary

The activities combobox content is loaded asynchronously,
we are storing the configured value for the window rule
until the activity list is loaded into the combo box.
And then, we set that item as the current one in the combo.

Diff Detail

Repository
R108 KWin
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
ivan updated this revision to Diff 6902.Sep 24 2016, 8:40 AM
ivan retitled this revision from to [kwinrules] Properly setting the value of the activity combo box.
ivan updated this object.
ivan edited the test plan for this revision. (Show Details)
ivan added a reviewer: KWin.
Restricted Application added a project: KWin. · View Herald TranscriptSep 24 2016, 8:40 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
mart accepted this revision.Sep 24 2016, 12:13 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Sep 24 2016, 12:13 PM

This looks like editing the rule while the activity daemon does not respond (in time) is prone to alter the setting?
Maybe disable the combo until there's response from the activity dameon and ensure to not write back the setting until it's enabled?

ivan added a comment.Sep 24 2016, 5:11 PM

Maybe disable the combo until there's response from the activity
dameon and ensure to not write back the setting until it's enabled?

This should be a non issue. The response time is short.

Disabling the combo (and the checkbox) would be a more intrusive change for not much gain.

This revision was automatically updated to reflect the committed changes.