Require and use the new NewStuffQuick Button component
ClosedPublic

Authored by leinir on Oct 25 2019, 12:43 PM.

Details

Summary

This removes the need for the custom hack for spawning a dialog,
and is intended to function as a sample for how to implement this
in other KCMs.

Also use the big, pretty Preview mode (because super-visual content)

This could be done wholesale for the entire bunch of KCMs, but i post
this on its own in an attempt to gain feedback on a self contained
example of how to do this porting step.

Without this patch:

With this patch:

Depends on D25041

Diff Detail

Repository
R119 Plasma Desktop
Branch
use-newstuffquick-in-lookandfeel-kcm (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18299
Build 18317: arc lint + arc unit
leinir created this revision.Oct 25 2019, 12:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 25 2019, 12:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
leinir requested review of this revision.Oct 25 2019, 12:43 PM
leinir edited the summary of this revision. (Show Details)Oct 25 2019, 12:47 PM
leinir added reviewers: Plasma, KNewStuff, VDG, broulik.

Nice. However it doesn't seem to work for me. If I install a theme using the dialog, it doesn't show up in the Global Themes KCM. Could it because of a typo (changedEntryes.count()) ?

I've filed a bunch of bug reports regarding polishing the dialog itself:

leinir updated this revision to Diff 68958.Oct 29 2019, 10:03 AM

Together with the change in D25041 this makes the model reloading work
(without that patch, it simply fails quietly as the signal forwarding
fails). If wanted, we could also use the count property in the same
diff to reintroduce the previous logic (which of course would then
require that patch having been merged first)

  • Simplify the model reload logic a touch
ngraham accepted this revision.Oct 29 2019, 4:08 PM

Thanks, that fixes the issue. This works quite well now.

Would be nice to address the bugs I filed before 5.18 is released so it really gets polished up all nice and shiny. :)

This revision is now accepted and ready to land.Oct 29 2019, 4:08 PM

Thanks, that fixes the issue. This works quite well now.

Would be nice to address the bugs I filed before 5.18 is released so it really gets polished up all nice and shiny. :)

Thanks for the confirmation! :)

Definitely would, i'm endeavouring to run through the issues quick as possible :)

This revision was automatically updated to reflect the committed changes.