Differential D25007

Making display of x axis cofigurable
ClosedPublic
Actions

Authored by wreissenberger on Oct 28 2019, 2:44 PM.

Details

Reviewers

mutlaqja

Commits

R321:bf020d440335: Making display of x axis cofigurable

Summary

Some optimizations for the display of sensor data:

The range displayed on the y axis is either limited by the value range or - configurable - including the x axis.
Bugfix - action timer starts only when at least one action is selected.
Layout optimizations

Diff Detail

Repository

R321 KStars

Branch

observatory_sensor_display

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18279
Build 18297: arc lint + arc unit

wreissenberger created this revision.Oct 28 2019, 2:44 PM

Restricted Application added a project: KDE Edu. · View Herald TranscriptOct 28 2019, 2:44 PM

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

wreissenberger requested review of this revision.Oct 28 2019, 2:44 PM

Harbormaster completed remote builds in B18254: Diff 68886.Oct 28 2019, 2:44 PM

wreissenberger added a reviewer: mutlaqja.Oct 28 2019, 2:45 PM

I'm still not sure what "show x axis" means exactly. Feeling pretty stupid now.

I'm still not sure what "show x axis" means exactly.

Show x axis selected:

Not selected

Do you have a better name?

X Axis Selected --> Show all range on Y-Axis starting from zero?

X axis is time
Y axis is value, so show X-axis means show time. This is still confusing.

Maybe you mean "Auto Scale Y-axis or value-axis" ?

Maybe you mean "Auto Scale Y-axis or value-axis" ?

That sounds best. But in this case, the logic is vice versa. When then check box is selected, the value axis is scaled to [min, max], right?

Yes absolutely, the logic is reversed in that manner.

Auto scale instead of show x axis reverses the logic

Harbormaster completed remote builds in B18279: Diff 68922.Oct 28 2019, 9:42 PM

Unrelated to this PR, but I noticed that both CW and CCW are always active/RED when in INDI control panel, both are off.

mutlaqja accepted this revision.Oct 29 2019, 7:55 AM

This revision is now accepted and ready to land.Oct 29 2019, 7:55 AM

Closed by commit R321:bf020d440335: Making display of x axis cofigurable (authored by wreissenberger, committed by mutlaqja). · Explain WhyOct 29 2019, 7:56 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kstars/ekos/observatory/observatory.h (1 line)
M			kstars/ekos/observatory/observatory.cpp (44 lines)
M			kstars/ekos/observatory/observatory.ui (274 lines)
M			kstars/ekos/observatory/observatoryweathermodel.h (9 lines)
M			kstars/ekos/observatory/observatoryweathermodel.cpp (7 lines)
M			kstars/kstars.kcfg (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	68886	1407f3f		Oct 28 2019, 2:44 PM	★	★
Diff 2	68922	1407f3f	Auto scale instead of show x axis reverses the logic	Oct 28 2019, 9:42 PM	★	★
Diff 3	68950	a6f633b	R321:bf020d440335630b4bb021b54d34e837da24b022	Oct 29 2019, 7:56 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
820be5a83667	09d3854060c3	e7a36306b1ab	Wolfgang Reissenberger	Auto scale instead of show x axis reverses the logic	Oct 28 2019, 9:40 PM
e7a36306b1ab	f9453f44ee39	ea0ddad0b48a	Wolfgang Reissenberger	Bugfix - action timer starts only when at least one action is selected	Oct 28 2019, 2:41 PM
ea0ddad0b48a	b86238f24ff2	1407f3fcb946	Wolfgang Reissenberger	Making display of x axis cofigurable + layout optimizations	Oct 28 2019, 2:34 PM