Also this patch's title could use some changes. Please rewrite it in the form of a statement that explains the change or fix, not the problem.

Friendly ping.

Turning a number into a string and back again isn't ideal

I would suggest:

int dpiValue = dpiConfigGroup.readEntry("forceFontDPI", -1);


if (dpiValue  > 24) {
     const QString dpiArgument = QStringLiteral("-dpi ") + QString::number(dpiValue);
    args[QStringLiteral("kde_settings.conf/X11/ServerArguments")] = dpiArgument;
}

Though I'm not sure I fully understand why we have this sort of wrong value in the config anyway?

Also do we want

} else {
        args[QStringLiteral("kde_settings.conf/X11/ServerArguments")] = QString();
}

so that a broken DPI wipes the old config entry out? Not sure.

Though I'm not sure I fully understand why we have this sort of wrong value in the config anyway?

The problem coming from force font DPI code so far I see.
Now the min/max & steps to scale down/up are fixed in the UI but any reset to default
enable/disable a DPI value there will write a forceFontDPI=0 in the config file which seems to mean disabled.
I am not sure why we need to write a 0 on reset/disable since default has nothing also.

However, even if we fix there we may still want to be sure the value is a number and >= 24, at least in my opinion.
People do crazy stuff even writing manually or with scripts to configuration files.

Also do we want

} else {
        args[QStringLiteral("kde_settings.conf/X11/ServerArguments")] = QString();
}

so that a broken DPI wipes the old config entry out? Not sure.

Not sure about that either but maybe a good idea.

David's suggestion to just turn dpiValue into an int sounds sensible to me. @gcraciunescu do you want to finish this patch?

In D25006#605578, @filipf wrote:

David's suggestion to just turn dpiValue into an int sounds sensible to me. @gcraciunescu do you want to finish this patch?

I think you guys need to agree on something first. I don' mind if someone else commits a fix for that.