[Applet] Show more information in the Details tab
ClosedPublic

Authored by mibofra on Oct 25 2019, 2:32 AM.

Details

Summary

I apologize if I annoy someone with this request, as here https://bugs.kde.org/show_bug.cgi?id=361414 I've seed it has been discussed the issue, and it was done a survey to choice the displayed info.

But, as written in comment #10 of the bug, I don't know why a mac address has more relevance for an average user than an nameserver or a gateway. And usually the average user don't see this section of the plasmoid.

So, I'm submitting to the review process this patch, with hope of being accepted.

It adds just the possibility to see, with the related present info, the current dns (first one) for IPv4 and v6 connectivity, and the current default gateway for the IPv4 connectivity.

FEATURE: 361414
FIXED-IN: 5.18.0

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Lint Skipped
Unit
Unit Tests Skipped
mibofra created this revision.Oct 25 2019, 2:32 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 25 2019, 2:32 AM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mibofra requested review of this revision.Oct 25 2019, 2:32 AM
jgrulich requested changes to this revision.Oct 25 2019, 4:52 AM
jgrulich added inline comments.
libs/models/networkmodelitem.cpp
548

Because this if statement is the same as the one above and below, can you move them together?

575

Same for this one.

This revision now requires changes to proceed.Oct 25 2019, 4:52 AM
mibofra updated this revision to Diff 68739.Oct 25 2019, 10:35 AM

I've updated the diff!

jgrulich accepted this revision.Oct 25 2019, 10:41 AM
This revision is now accepted and ready to land.Oct 25 2019, 10:41 AM
ngraham edited the summary of this revision. (Show Details)Oct 25 2019, 1:20 PM
ngraham added a subscriber: ngraham.Dec 5 2019, 8:53 PM

@mibofra sorry this got lost. Can you provide your email address so we can land the patch with correct authorship information?

@mibofra sorry this got lost. Can you provide your email address so we can land the patch with correct authorship information?

Sure, mibofra@parrotsec.org

ngraham retitled this revision from Enchanting/Showing more informations on the info section of plasma-nm plasmoid to [Applet] Show more information in the Details tab.Dec 5 2019, 9:09 PM
This revision was automatically updated to reflect the committed changes.