Differential D24924

Don't reset model when adding an active connection
ClosedPublic
Actions

Authored by nicolasfella on Oct 24 2019, 2:09 PM.

Details

Reviewers
jgrulich
Commits
R116:6929300787ac: Don't reset model when adding an active connection
Summary

same resoning as in D24903

Diff Detail

Repository
R116 Plasma Network Management Applet
Branch
updavail
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18129
Build 18147: arc lint + arc unit
nicolasfella created this revision.Oct 24 2019, 2:09 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 24 2019, 2:09 PM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Oct 24 2019, 2:09 PM
jgrulich accepted this revision.Oct 24 2019, 3:04 PM
This revision is now accepted and ready to land.Oct 24 2019, 3:04 PM
jgrulich requested changes to this revision.Oct 24 2019, 3:08 PM
jgrulich added inline comments.
libs/models/networkmodel.cpp
313

Shouldn't you add item->changedRoles() as the last parameter?

This revision now requires changes to proceed.Oct 24 2019, 3:08 PM
nicolasfella updated this revision to Diff 68691.Oct 24 2019, 3:17 PM
  • Only emit changed roles
jgrulich accepted this revision.Oct 24 2019, 3:19 PM
This revision is now accepted and ready to land.Oct 24 2019, 3:19 PM
jgrulich requested changes to this revision.Oct 24 2019, 3:20 PM

Actually, I just checked our code and we use updateItem(item) function, which does the emitting and will clear the roles automatically.

This revision now requires changes to proceed.Oct 24 2019, 3:20 PM
jgrulich added a comment.Oct 24 2019, 3:21 PM
In D24924#553460, @jgrulich wrote:

Actually, I just checked our code and we use updateItem(item) function, which does the emitting and will clear the roles automatically.

Can you change it in other PRs too and even in the one you pushed in the morning?

nicolasfella updated this revision to Diff 68695.Oct 24 2019, 3:31 PM
  • Only emit changed roles
  • Use updateItem
jgrulich accepted this revision.Oct 24 2019, 3:33 PM
This revision is now accepted and ready to land.Oct 24 2019, 3:33 PM
Closed by commit R116:6929300787ac: Don't reset model when adding an active connection (authored by nicolasfella). · Explain WhyOct 24 2019, 3:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlibs/models/networkmodel.cpp (5 lines)

Diff 68691

View Options

libs/models/networkmodel.cpp

Loading...