Differential D24905

Use return early
ClosedPublic
Actions

Authored by nicolasfella on Oct 23 2019, 9:55 PM.

Details

Reviewers
jgrulich
Commits
R116:f301f1ead38a: Use return early
Summary

Makes the code more readable by reducing the indentation depth

Diff Detail

Repository
R116 Plasma Network Management Applet
Branch
returnearly
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18105
Build 18123: arc lint + arc unit
nicolasfella created this revision.Oct 23 2019, 9:55 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 23 2019, 9:55 PM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Oct 23 2019, 9:55 PM
jgrulich accepted this revision.Oct 24 2019, 5:28 AM
This revision is now accepted and ready to land.Oct 24 2019, 5:28 AM
broulik added a subscriber: broulik.Oct 24 2019, 8:05 AM

I think all of thise breaks in loops must be continues?

libs/models/networkmodel.cpp
457

Shouldn't this be a continue?

846

continue?

jgrulich added a comment.Oct 24 2019, 8:16 AM
In D24905#553119, @broulik wrote:

I think all of thise breaks in loops must be continues?

Good catch.

jgrulich requested changes to this revision.Oct 24 2019, 10:14 AM
This revision now requires changes to proceed.Oct 24 2019, 10:14 AM
nicolasfella updated this revision to Diff 68658.Oct 24 2019, 10:20 AM
  • s/break/continue
  • Fixup
jgrulich accepted this revision.Oct 24 2019, 10:24 AM
This revision is now accepted and ready to land.Oct 24 2019, 10:24 AM
Closed by commit R116:f301f1ead38a: Use return early (authored by nicolasfella). · Explain WhyOct 24 2019, 10:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlibs/models/networkmodel.cpp (346 lines)

Diff 68658

View Options

libs/models/networkmodel.cpp

Loading...