Notification applet on the phone
ClosedPublic

Authored by mart on Oct 18 2019, 4:07 PM.

Details

Summary

some optimizations for tablet mode (touch first, but also on
transformable laptops flipped to tablet)
and some for specifically the mobile case (mobile phone)

  • hide the top toolbar in phone mode
  • in tablet mode (and therefore on phone mode too) don't select text but drag the item laterally to dismiss it
Test Plan
  • on phone form factor for the new behavior
  • on touch laptop in tablet mode
  • on desktop for its behavior not changing at all

Diff Detail

Repository
R120 Plasma Workspace
Branch
mart/mobilenotifications
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18021
Build 18039: arc lint + arc unit
mart created this revision.Oct 18 2019, 4:07 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 18 2019, 4:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Oct 18 2019, 4:07 PM
mart planned changes to this revision.Oct 18 2019, 4:08 PM
mart requested review of this revision.

behavior on mobile

bshah awarded a token.Oct 18 2019, 9:06 PM
mart updated this revision to Diff 68455.Oct 21 2019, 4:18 PM
  • don't show jobs in popups on mobile
mart retitled this revision from [WIP] Notification applet on the phone to Notification applet on the phone.Oct 21 2019, 4:19 PM
mart updated this revision to Diff 68517.Oct 22 2019, 9:59 AM
  • always show jobs
mart updated this revision to Diff 68518.Oct 22 2019, 10:00 AM
  • remove unused import
broulik accepted this revision.Oct 22 2019, 10:01 AM
This revision is now accepted and ready to land.Oct 22 2019, 10:01 AM
This revision was automatically updated to reflect the committed changes.