Improve panel options menu entries
ClosedPublic

Authored by GB_2 on Sep 14 2019, 9:13 PM.

Details

Summary
  • Move "Panel Options" context menu items out of submenu
  • Rename "Configure Panel..." option

See M144, T10047, T10190. This makes the panel customization options much more discoverable.

Test Plan

Open the panel context menu.

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
arcpatch-D23951
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17988
Build 18006: arc lint + arc unit
GB_2 created this revision.Sep 14 2019, 9:13 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 14 2019, 9:13 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
GB_2 requested review of this revision.Sep 14 2019, 9:13 PM
GB_2 edited the test plan for this revision. (Show Details)Sep 14 2019, 9:16 PM

Two things with this patch series:

  1. Now there's no way to lock widgets without entering panel edit mode. Feels like we might as well just get rid of unlocked mode entirely. Or are more patches coming? Did we ever come to a conclusion in T10190?
  1. Since this is a Frameworks change and will/would land in 5.63, we can't depend on having it for Plasma 5.17. If D23950 does not work without this frameworks change, then here are our options:
    • Delay D23950 until Plasma 5.18 (maybe for the best if the final UX is not clear yet)
    • Ask Frameworks packagers to re-spin plasma-framework for 5.62 to include this change once it's accepted
    • Do it anyway and hope no discrete release distros decide to ship Plasma 5.17 with Frameworks 5.62 for years and years
GB_2 added a comment.Sep 15 2019, 6:09 AM

Two things with this patch series:

  1. Now there's no way to lock widgets without entering panel edit mode. Feels like we might as well just get rid of unlocked mode entirely. Or are more patches coming? Did we ever come to a conclusion in T10190?

Right, I think we'll need to discuss it a bit more.

  • Delay D23950 until Plasma 5.18 (maybe for the best if the final UX is not clear yet)

Yeah, then we have some more time to think about the UX and test it.

GB_2 edited the summary of this revision. (Show Details)Sep 15 2019, 6:10 AM
GB_2 edited the summary of this revision. (Show Details)Sep 15 2019, 6:55 AM
GB_2 updated this revision to Diff 66103.Sep 15 2019, 8:22 AM

Only show "Unlock Widgets" in the UI and only show "Show Alternatives..." in panel edit mode

GB_2 retitled this revision from Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option to Improve desktop layout and panel editing UX.Sep 15 2019, 8:28 AM
GB_2 edited the summary of this revision. (Show Details)

OK cool, let's move the general UX discussion back into T10190 and use these just for implementation discussion.

GB_2 updated this revision to Diff 66160.Sep 15 2019, 9:15 PM

Add back "Show Alternatives..." item

GB_2 updated this revision to Diff 66162.Sep 15 2019, 9:17 PM

Really add back "Show Alternatives..." item

GB_2 edited the summary of this revision. (Show Details)Sep 15 2019, 9:17 PM
GB_2 edited the summary of this revision. (Show Details)Sep 15 2019, 9:30 PM
GB_2 updated this revision to Diff 66668.Sep 23 2019, 3:30 PM

Fix diff

+1 in general, but since this removes the GUI ability to enter locked mode, it can't land until D23952 is ready, which means we need to wait for a visible non-right-click method to enter Panel Edit Mode. Maybe for now we can put that in the Desktop Toolbox lol.

GB_2 added a comment.EditedSep 24 2019, 4:29 PM

+1 in general, but since this removes the GUI ability to enter locked mode, it can't land until D23952 is ready, which means we need to wait for a visible non-right-click method to enter Panel Edit Mode. Maybe for now we can put that in the Desktop Toolbox lol.

What if we don't remove the panel toolbox yet, but only show it when the desktop toolbox is open, similar to how widget controls used to be shown when you have the desktop toolbox open?

GB_2 added a comment.Sep 24 2019, 5:17 PM

we need to wait for a visible non-right-click method to enter Panel Edit Mode.

I think we'll need a task for that.

In D23951#537209, @GB_2 wrote:

+1 in general, but since this removes the GUI ability to enter locked mode, it can't land until D23952 is ready, which means we need to wait for a visible non-right-click method to enter Panel Edit Mode. Maybe for now we can put that in the Desktop Toolbox lol.

What if we don't remove the panel toolbox yet, but only show it when the desktop toolbox is open, similar to how widget controls used to be shown when you have the desktop toolbox open?

Ooh, I like that.

mart accepted this revision.Sep 25 2019, 12:24 PM
This revision is now accepted and ready to land.Sep 25 2019, 12:24 PM
GB_2 added 1 blocking reviewer(s): Plasma.Sep 27 2019, 4:17 AM
This revision now requires review to proceed.Sep 27 2019, 4:17 AM
GB_2 retitled this revision from Improve desktop layout and panel editing UX to Improve and clean up panel options menu entries.Oct 12 2019, 2:06 PM

Ping.

It's already accepted by Marco isn't it?

src/plasma/containment.cpp
126

"name of the containment" surely?

mart added a comment.EditedOct 21 2019, 4:11 PM

i'm not sure i would hardcode the behavior Only show "Unlock Widgets" in the UI (hide "Lock Widgets" from the UI) i would try to go from the context menu plugin instead and not adding the action there by default (but still possible to add it)
apart from that, it looks good

mart requested changes to this revision.Oct 21 2019, 4:11 PM
This revision now requires changes to proceed.Oct 21 2019, 4:11 PM
GB_2 added a comment.Oct 21 2019, 4:12 PM
This comment was removed by GB_2.
mart added a comment.Oct 21 2019, 4:17 PM

probably some special casing for that action will still be needed in the panel, but should be ok

GB_2 marked an inline comment as done.Oct 21 2019, 4:50 PM
This comment was removed by GB_2.
GB_2 updated this revision to Diff 68467.Oct 21 2019, 5:32 PM

Don't hide lock action here

GB_2 retitled this revision from Improve and clean up panel options menu entries to Improve panel options menu entries.Oct 21 2019, 5:32 PM
GB_2 edited the summary of this revision. (Show Details)
GB_2 edited the summary of this revision. (Show Details)
mart accepted this revision.Oct 21 2019, 5:52 PM
This revision is now accepted and ready to land.Oct 21 2019, 5:52 PM
This revision was automatically updated to reflect the committed changes.