Details
- Reviewers
mart - Group Reviewers
Plasma VDG - Maniphest Tasks
- T10402: Find a way to remove the Desktop Toolbox in its current form (i.e. a hamburger menu button in the corner of the screen)
T11094: Improve discoverability of widget configuration
T10190: (Re)define modes when editing panels and widgets - Commits
- R242:bbe0148db5d1: Improve panel options menu entries
Open the panel context menu.
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Branch
- arcpatch-D23951
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 17988 Build 18006: arc lint + arc unit
Two things with this patch series:
- Now there's no way to lock widgets without entering panel edit mode. Feels like we might as well just get rid of unlocked mode entirely. Or are more patches coming? Did we ever come to a conclusion in T10190?
- Since this is a Frameworks change and will/would land in 5.63, we can't depend on having it for Plasma 5.17. If D23950 does not work without this frameworks change, then here are our options:
- Delay D23950 until Plasma 5.18 (maybe for the best if the final UX is not clear yet)
- Ask Frameworks packagers to re-spin plasma-framework for 5.62 to include this change once it's accepted
- Do it anyway and hope no discrete release distros decide to ship Plasma 5.17 with Frameworks 5.62 for years and years
Right, I think we'll need to discuss it a bit more.
- Delay D23950 until Plasma 5.18 (maybe for the best if the final UX is not clear yet)
Yeah, then we have some more time to think about the UX and test it.
Only show "Unlock Widgets" in the UI and only show "Show Alternatives..." in panel edit mode
OK cool, let's move the general UX discussion back into T10190 and use these just for implementation discussion.
+1 in general, but since this removes the GUI ability to enter locked mode, it can't land until D23952 is ready, which means we need to wait for a visible non-right-click method to enter Panel Edit Mode. Maybe for now we can put that in the Desktop Toolbox lol.
What if we don't remove the panel toolbox yet, but only show it when the desktop toolbox is open, similar to how widget controls used to be shown when you have the desktop toolbox open?
Ping.
It's already accepted by Marco isn't it?
src/plasma/containment.cpp | ||
---|---|---|
126 | "name of the containment" surely? |
i'm not sure i would hardcode the behavior Only show "Unlock Widgets" in the UI (hide "Lock Widgets" from the UI) i would try to go from the context menu plugin instead and not adding the action there by default (but still possible to add it)
apart from that, it looks good
probably some special casing for that action will still be needed in the panel, but should be ok