Differential D24814

[KCMs] Make spinboxes editable
ClosedPublic
Actions

Authored by ngraham on Oct 21 2019, 1:47 AM.

Details

Reviewers
None
Group Reviewers
VDG
Plasma
Commits
R119:4f90a137e7a3: [KCMs] Make spinboxes editable
Summary

Otherwise they're annoying to use because you can only interact with them using a scroll
or by clicking on the tiny arrows.

Test Plan

You can now enter text in the spinboxes

Diff Detail

Repository
R119 Plasma Desktop
Branch
editable-spinboxes (branched from Plasma/5.17)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17987
Build 18005: arc lint + arc unit
ngraham created this revision.Oct 21 2019, 1:47 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 21 2019, 1:47 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 21 2019, 1:47 AM
ngraham updated this revision to Diff 68464.Oct 21 2019, 5:11 PM

Add valueFromText handlers

ngraham edited the test plan for this revision. (Show Details)Oct 21 2019, 5:16 PM

Landing without explicit approval since D24816 which does the exact same thing elsewhere was approved, and the logic for approving is identical. :)

This revision was not accepted when it landed; it landed in state Needs Review.Oct 21 2019, 5:17 PM
Closed by commit R119:4f90a137e7a3: [KCMs] Make spinboxes editable (authored by ngraham). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 68464

View Options

kcms/fonts/package/contents/ui/main.qml

Loading...
View Options

kcms/launch/package/contents/ui/main.qml

Loading...