Add edit-opacity icons
ClosedPublic

Authored by trickyricky26 on Oct 18 2019, 10:01 AM.

Details

Summary

This patch adds edit-opacity icons requested by Okular for D15580.

I'm not quite sure about the naming, and even if the Qt SVG renderer can handle this transparency. I also considered a style with a checkerboard pattern, which is the symbol for transparency e.g. in GIMP, but I felt this is not recognizable enough to most people. If you search for a opacity/transparency icon, you often find something with two overlapping circles, however I think that would be too close to our path-intersection etc. icons.

I think this should be the last icon needed for https://bugs.kde.org/show_bug.cgi?id=408283, so I'm tagging this as closing that bug.

BUG: 408283
FIXED-IN: 5.64

Test Plan

The new edit-opacity icons:

Diff Detail

Repository
R266 Breeze Icons
Branch
arcpatch-D24753
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17876
Build 17894: arc lint + arc unit
trickyricky26 created this revision.Oct 18 2019, 10:01 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 18 2019, 10:01 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
trickyricky26 requested review of this revision.Oct 18 2019, 10:01 AM
trickyricky26 edited the test plan for this revision. (Show Details)Oct 18 2019, 10:04 AM
trickyricky26 added a reviewer: VDG.
trickyricky26 edited the summary of this revision. (Show Details)Oct 18 2019, 10:09 AM
trickyricky26 edited the test plan for this revision. (Show Details)

Nice. I think the filled in areas might benefit from being a little bit more transparent to make it more obvious, particularly for the Breeze Dark version. Just a smidge.

  • Remove top stripe, reduce the opacity of the remaining stripes
trickyricky26 edited the test plan for this revision. (Show Details)Oct 18 2019, 7:37 PM
ngraham accepted this revision as: ngraham.Oct 18 2019, 8:56 PM
ngraham added a subscriber: ndavis.

@ndavis, you good with this?

This revision is now accepted and ready to land.Oct 18 2019, 8:56 PM
ndavis accepted this revision.Oct 18 2019, 11:57 PM
Closed by commit R266:36993fdded88: Add edit-opacity icons (authored by Rafael Brandmaier <rafael.brandmaier@kdemail.net>). · Explain WhyOct 19 2019, 9:03 PM
This revision was automatically updated to reflect the committed changes.

First, thanks for the excellent work on the new icons for Okular. I really like them.

I have noticed that the edit-opacity icon does not render correctly in some cases:


Preview in Cuttlefish.


Okular annotation toolbar

First, thanks for the excellent work on the new icons for Okular. I really like them.

I have noticed that the edit-opacity icon does not render correctly in some cases:


Preview in Cuttlefish.


Okular annotation toolbar

Huh, I noticed that when copying the files in Dolphin, the preview also showed this exact distortion of the 22px icon (but not the 16px one). I'll see if I can make this work.