| ngraham |
| Plasma | |
| VDG |
The new version of dialog allows you to select any application if associated applications are not what users want. The dialog
also now uses model and view, where the view is written in QML as QWidgets don't have anything like QGridView.
Screenshot of the dialog:
| No Linters Available |
| No Unit Test Coverage |
| Buildable 17846 | |
| Build 17864: arc lint + arc unit |
This is the initial state of the dialog, which presents only apps associated with given mimetype. Then if you click at the button below, it will show all the apps and provide a search bar.
The highlighted application is application which was used last time for the given mimetype. I don't otherwise use highlight for the apps when moving with mouse over them.
I would add text on the button e.g "Show more", otherwise it's quite difficult to know how to show more apps
Give the scrollview a frame and a white background or else apps look cut off and weird and there's a mysteriously hovering scroller:
Also why are there duplicates in here?
Finally, I would consider adding the "Other applications are available in Discover" text to the bottom, so it doesn't interrupt the dialog's flow.
| src/qml/AppChooserDialog.qml | ||
|---|---|---|
| 123 | Change the cursor to the pointing hand cursor when hovering over something that will immediately perform an action when clicked | |
| 141 | Allow this label to become a multi-line string for apps that have long-ish names:  | |
Give the scrollview a frame and a white background or else apps look cut off and weird and there's a mysteriously hovering scroller:
Also why are there duplicates in here?
From the screenshot I can see you use the current version of the dialog. Make sure you installed it to the correct location, on my system (Fedora) it's installed to /usr/libexec/xdg-desktop-portal-kde.
I'm not sure about that, because we already have the button and the search bar at the botttom.
On my system, it's at /usr/lib64/libexec/xdg-desktop-portal-kde. I tried overriding that file with the one I just built from source (because it didn't seem to use the built-from-source one at ~/kde/usr/lib64/libexec/xdg-desktop-portal-kde) but even then, I still get the old dialog in the Flatpak version of Dolphin. What am I doing wrong here?
Did you kill the previous one? It might still be running and that's why it didn't pick the new dialog. You can also start it manually, just kill any xdg-desktop-portal-kde instance and run the one you want (from any location). It will even tell you it's already running when you use "QT_LOGGING_RULES='xdp*.debug=true'".
Aha, the old one was indeed still running! I can see the new one now.
| src/qml/AppChooserDialog.qml | ||
|---|---|---|
| 99 | Set left and right anchors too so it takes up the full width | |
| 103 | Capitalize the S | |
So close! You don't need to create a Rectangle to give the ScrollView a white background; just set Component.onCompleted: background.visible = true on the scrollview itself. Here's an example of how it's done in the Notifications KCM: https://cgit.kde.org/plasma-desktop.git/tree/kcms/notifications/package/contents/ui/SourcesPage.qml#n94
Updated screenshot:
To be honest, I liked the result more when the "view" wasn't using a different background.
There still isn't a border around the inner view. That's what I'm trying to get there. Otherwise it doesn't look like an inner view; it looks like a floating rectangle.
Solved now. I used same border which is used in Kirigami components. I also added small rounding for the highlight, which I think makes it little more nicer.
