- Allow code reuse
Details
Details
- Reviewers
mart ervin davidedmundson - Group Reviewers
Plasma - Commits
- R119:f53d7844fbb5: Port kcm cursor to KConfigXT
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 17483 Build 17501: arc lint + arc unit
kcms/cursortheme/CMakeLists.txt | ||
---|---|---|
22 | Can you also add install(FILES kded/touchpaddaemon.kcfg DESTINATION ${KDE_INSTALL_KCFGDIR}) This doesn't explicitly do anything useful, but it allows future metadata extraction for documentation purposes. | |
kcms/cursortheme/kcmcursortheme.cpp | ||
72 | I assume Kevin's patch set fixes this? |
kcms/cursortheme/CMakeLists.txt | ||
---|---|---|
22 | Interestingly you didn't request that on my desktoptheme work. | |
kcms/cursortheme/cursorthemesettings.kcfg | ||
9 | Why those includes? They seem unused now since you're not having code in defaults. | |
kcms/cursortheme/kcmcursortheme.cpp | ||
72 | Yes, giving a bit more time to people to review the latest revisions of my KConfig patches. They changed quite a bit and I didn't get further comment yet. | |
kcms/cursortheme/kcmcursortheme.h | ||
127 | Why the empty line removal? The previous line is now stuck with the comment. |
Comment Actions
Just a last nitpick.
kcms/cursortheme/CMakeLists.txt | ||
---|---|---|
24 | Could that be moved in the install file section of the file? Everything related to file installs (but not target installs...) seems to be at the end of that file. |