The opacity binding overrides PrivateActionToolButton's enabled binding,
which means an Action's enabled property does not get checked for
ActionToolBar buttons.
Details
Details
- Reviewers
ngraham mart - Group Reviewers
Kirigami - Commits
- R169:4479e865be45: Properly check enabled state of Action for ActionToolBar buttons
With kirigami2gallery, on the Misc Widgets page, change the enabled property
of one of the actions in the toolbar. Observe that the tool button now gets
disabled correctly.
Diff Detail
Diff Detail
- Repository
- R169 Kirigami
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
+1 otherwise
src/controls/ActionToolBar.qml | ||
---|---|---|
126 | I'd do the enabled && opacity, it feels very wrong using a real number as a boolean >.<. |
src/controls/ActionToolBar.qml | ||
---|---|---|
126 | Agreed. I made the opacity check more explicit. |