Move Amusement to Games directory instead of Games > Toys
ClosedPublic

Authored by guoyunhe on Oct 3 2019, 11:15 AM.

Details

Summary

The Amusement category doesn't mean it is about toys.

BUG: 412553

Diff Detail

Repository
R309 KService
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17286
Build 17304: arc lint + arc unit
guoyunhe created this revision.Oct 3 2019, 11:15 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 3 2019, 11:15 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
guoyunhe requested review of this revision.Oct 3 2019, 11:15 AM
GB_2 edited the summary of this revision. (Show Details)Oct 3 2019, 1:51 PM
aacid added a subscriber: aacid.Oct 3 2019, 4:35 PM

Have you contacted Valve to tell them amusement is the wrong category for Steam?

Because the spec says Amusement - > a simple amusement

And that's not what steam is

IMHO this patch is wrong and steam is what needs fixing.

Have you contacted Valve to tell them amusement is the wrong category for Steam?

Because the spec says Amusement - > a simple amusement

And that's not what steam is

IMHO this patch is wrong and steam is what needs fixing.

Dispite what Steam belongs to, "a simple amusement" should not be named "toys". Do we have any applications or games that are "toys"?

ngraham added a reviewer: VDG.Oct 3 2019, 6:05 PM

I agree with @guoyunhe. "Toys" isn't an appropriate word to use in the context of computers and software. From a native English speaker's perspective here, a toy is something physical that you give to children. Using the word to describe something anything else is actually insulting to that thing ("don't use that app, it's a toy compared to this other one") and by extension, the people who created it.

aacid added a comment.Oct 3 2019, 6:43 PM

Really? toys are only for children and adults should be ashamed to play with toys? Come on, i thought we were past that.

Anyway, i'm really confused now, does your Stream have the Amusement category?

Because the steam.desktop from http://repo.steampowered.com/steam/pool/steam/s/steam/steam_1.0.0.61.tar.gz says

Categories=Network;FileTransfer;Game;

Which Steam version are you running?

No, i don't know of any app that we have (or otherwise) that uses the Amusement category

aacid added a comment.Oct 3 2019, 6:43 PM

Lol it's opensuse being silly, oh well.

ngraham accepted this revision.Oct 3 2019, 10:42 PM

Really? toys are only for children and adults should be ashamed to play with toys? Come on, i thought we were past that.

Maybe it's different in your native language and country. But in English, and in the USA, there's a clear stigma to describing something not designed to be a children's plaything as a toy.

I don't appreciate the flippant and dismissive attitude in that comment. I would ask that you interact with more respectfulness. Thanks.

This revision is now accepted and ready to land.Oct 3 2019, 10:42 PM
aacid added a comment.Oct 3 2019, 10:50 PM

I don't appreciate the flippant and dismissive attitude in that comment. I would ask that you interact with more respectfulness. Thanks.

Can you please at least remove the steam example from the commit message, as it is not relevant (it is a downstream change) and remove the reference to the bug?
Does it also mean that kf5-toys.directory is not used anymore? (not sure whether it can't be removed anyway for compatibility?)

guoyunhe updated this revision to Diff 67304.Oct 4 2019, 8:29 AM

Update description

guoyunhe edited the summary of this revision. (Show Details)Oct 4 2019, 8:30 AM

In RPM package groups, Amusement is a top level category and Game is its child category. So a game can be categorized as Amusement/Game/Other.

However, in freedesktop.org specification, Game is primary category. Amusement is secondary category but not under Game.

I searched through all KDE apps to find Amusement category in desktop files. And find the only one :

amor - Amusing Misuse of Resources animation that sits on top of the curent window. Categories=Qt;KDE;Game;Amusement;

guoyunhe updated this revision to Diff 67310.Oct 4 2019, 10:01 AM

In case Amusement is under other primary category, let it be placed in its actually primary category, rather than force it in Games.

guoyunhe added a comment.EditedOct 4 2019, 10:05 AM

If I install amor, it would be shown in both Games and Games > Toys. This patch will let it only shows in Games.

Another situation is that, if the application is Categories=Multimedia;Amusement;, it will not fit Games or Games>Toys. This patch can also help to always follow the primary category. (Amusement is an additional/secondary category)

@aacid do you think this makes sense?

This revision was automatically updated to reflect the committed changes.