Differential D24313

Rework compression quality settings
ClosedPublic
Actions

Authored by MrPepe on Sep 30 2019, 1:49 PM.

Details

Reviewers
ngraham
Group Reviewers
Spectacle
Commits
R166:3b34490655b1: Rework compression quality settings
Summary

Removed ticks from the slider.
Substituted the label with a SpinBox, also adding a percent sign.

Test Plan

Set compression quality using both the spinbox and the slider -> Quality of saved images changes accordingly

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
MrPepe created this revision.Sep 30 2019, 1:49 PM
Restricted Application added a project: Spectacle. · View Herald TranscriptSep 30 2019, 1:49 PM
MrPepe requested review of this revision.Sep 30 2019, 1:49 PM
MrPepe updated this revision to Diff 67160.Oct 2 2019, 2:45 AM
MrPepe retitled this revision from Remove ticks from compression quality slider and add percent sign to its label to Rework compression quality settings.
MrPepe edited the summary of this revision. (Show Details)
MrPepe edited the test plan for this revision. (Show Details)
MrPepe added a reviewer: ngraham.
ngraham accepted this revision.Oct 2 2019, 4:55 PM

Thanks for the patch! This is a nice complement to the Gwenview one (D24309) to make these user interfaces more consistent.

This revision is now accepted and ready to land.Oct 2 2019, 4:55 PM
ngraham edited the summary of this revision. (Show Details)Oct 2 2019, 4:56 PM

BTW:

The slider knob does not scale with bigger font sizes and I couldn't find an easy solution for that. Is there one?

That would probably be a bug in the Breeze widget style.

Closed by commit R166:3b34490655b1: Rework compression quality settings (authored by MrPepe, committed by ngraham). · Explain WhyOct 2 2019, 5:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 67160

View Options

src/Gui/SettingsDialog/SaveOptionsPage.cpp

Loading...