In D24189#536981, @davidedmundson wrote:

Generally++

Should we set it to true in the Deleted constructor? I imagine it's a special case that no-one queries, but technically it's ready for painting.

ready_for_painting gets copied to Deleted

see Toplevel::copyToDeleted

davidedmundson accepted this revision.Sep 24 2019, 2:04 PM

This revision is now accepted and ready to land.Sep 24 2019, 2:04 PM

Closed by commit R108:64feafc10fb5: Mark Toplevel as not ready for painting by default (authored by zzag). · Explain WhySep 24 2019, 2:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			client.cpp (1 line)
M			internal_client.cpp (3 lines)
M			toplevel.cpp (2 lines)
M			unmanaged.cpp (1 line)
M			xdgshellclient.cpp (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	66749	f67db3a		Sep 24 2019, 1:41 PM	★	★
Diff 2	66754	f67db3a	R108:64feafc10fb599ed3b8ac4943d8807200c550385	Sep 24 2019, 2:05 PM	★	★

Diff 66754

View Options

client.cpp

View Options

internal_client.cpp

View Options

toplevel.cpp

View Options

unmanaged.cpp

View Options

Mark Toplevel as not ready for painting by defaultClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 66754

client.cpp

internal_client.cpp

toplevel.cpp

unmanaged.cpp

xdgshellclient.cpp

Mark Toplevel as not ready for painting by default
ClosedPublic
Actions

Revision Contents
Changeset List