Only show "Add Widgets..." panel context menu option in panel edit mode
AbandonedPublic

Authored by GB_2 on Sep 14 2019, 9:13 PM.

Details

Reviewers
None
Group Reviewers
Plasma
VDG
Maniphest Tasks
T10190: (Re)define modes when editing panels and widgets
Summary

See M144, T10047, T10190. This cleans up the menu a bit, the hidden option is already available in panel edit mode.

Test Plan

Open the panel context menu.

Diff Detail

Repository
R120 Plasma Workspace
Branch
only-show-add-widgets-and-lock-widgets-panel-contextmenu-options-in-panel-edit-mode (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16562
Build 16580: arc lint + arc unit
GB_2 created this revision.Sep 14 2019, 9:13 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 14 2019, 9:13 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Sep 14 2019, 9:13 PM
GB_2 edited the summary of this revision. (Show Details)
GB_2 edited the test plan for this revision. (Show Details)Sep 14 2019, 9:16 PM
GB_2 edited the summary of this revision. (Show Details)Sep 15 2019, 6:10 AM
GB_2 updated this revision to Diff 66102.Sep 15 2019, 6:53 AM

Don't hide "Lock Widgets" for panels

GB_2 edited the summary of this revision. (Show Details)Sep 15 2019, 6:55 AM
GB_2 retitled this revision from Only show "Add Widgets..." and "Lock Widgets" panel context menu options in panel edit mode to Only show "Add Widgets..." panel context menu option in panel edit mode.Sep 15 2019, 6:57 AM
GB_2 edited the summary of this revision. (Show Details)Sep 15 2019, 7:00 AM
GB_2 edited the summary of this revision. (Show Details)Sep 15 2019, 8:32 AM
GB_2 edited the summary of this revision. (Show Details)Sep 15 2019, 9:30 PM
mart added a subscriber: mart.Sep 16 2019, 11:22 AM

i'm on the fence with that.
things can be editable to a certain extent always, like adding or removing widgets, and that should really remain so
otherwise... it would be a locked state, really, which behavior i really don't want as default, especially for desktop widgets.
I'm not completely against the change per se, but i still want to retain the difference between locked and not edit mode

In my mind, "locked" should be a semi-hidden state really only used by admins for locking down a machine's panel and widget configuration. The only reason why I currently use Locked mode is to get rid of the visible configure button in the panel. If it was hidden by default, and editing was accomplished by clicking on something else, speaking personally I would have no need to enter locked mode.

GB_2 abandoned this revision.Sep 22 2019, 7:46 PM
GB_2 edited the summary of this revision. (Show Details)Sep 23 2019, 3:48 PM
GB_2 removed a dependent revision: D23951: Improve panel options menu entries.