This patch brings feature parity with gnome's nm-connection-editor strongswan plugin. Enabling custom proposals is required in order to support connections to strict strong cipher endpoints, the default cipher list doesn't include eg: aes256gcm16-prfsha384-ecp384.
Details
Details
Diff Detail
Diff Detail
- Repository
- R116 Plasma Network Management Applet
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
plasma-nm-5.15.5/vpn/strongswan/strongswanprop.ui | ||
---|---|---|
291 ↗ | (On Diff #65357) | nitpick: "Cipher Proposals" |
295–299 ↗ | (On Diff #65357) | maybe use the checkable property of QGroupBox instead? |
plasma-nm-5.15.5/vpn/strongswan/strongswanwidget.cpp | ||
155–156 ↗ | (On Diff #65357) | should these be set only when the custom proposals are accepted? |
Comment Actions
I'm not sure the "Cipher Proposals" groupbox should be inside the "Options" groupbox, imo it should be separated groupbox
plasma-nm-5.15.5/vpn/strongswan/strongswanwidget.cpp | ||
---|---|---|
100 ↗ | (On Diff #65357) | Same here, probably pointless to set "IKE" and "ESP" when "Enable custom proposals" is false. |
155–156 ↗ | (On Diff #65357) | Indeed, they should be set only when the "Enable custom proposals" checkbox is checked. |
Comment Actions
Moved custom cipher proposals into its own group box, with the checked property, encompassing the IKE/ESP proposal QLineEdit boxes.
Comment Actions
Do not enable "Custom cipher proposals" by default, that forces everyone to uncheck it.