Add QIcon setters for the password dialogs
ClosedPublic

Authored by vkrause on Sep 12 2019, 1:46 PM.

Details

Summary

This avoids having to pass in QPixmaps with a fixed size.

Diff Detail

Repository
R236 KWidgetsAddons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16463
Build 16481: arc lint + arc unit
vkrause created this revision.Sep 12 2019, 1:46 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 12 2019, 1:46 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Sep 12 2019, 1:46 PM

Should we deprecate the pixmap methods in favor of the icon ones? Do we need an QIcon getter too?

cfeck added a subscriber: cfeck.Sep 12 2019, 2:11 PM

A getter would be nice. I am also fine with deprecating the pixmap calls. You can create an icon from a pixmap using QIcon.

(Why is there no setIcon() in QLabel?)

vkrause updated this revision to Diff 65948.Sep 12 2019, 9:30 PM

Add icon() getter, deprecated pixmap methods, remove on demand pixmap label creation as we set an icon unconditionally.

dfaure accepted this revision.Sep 13 2019, 8:27 AM
dfaure added inline comments.
src/knewpassworddialog.h
97

typo: represents

103

same

This revision is now accepted and ready to land.Sep 13 2019, 8:27 AM
vkrause updated this revision to Diff 65966.Sep 13 2019, 9:53 AM

Fix typos.

This revision was automatically updated to reflect the committed changes.