Differential D23816

[KItemViews] Port to non-deprecated QWheelEvent API
ClosedPublic
Actions

Authored by dfaure on Sep 10 2019, 8:00 AM.

Details

Reviewers
mlaurent
Commits
R276:55a8035f6507: [KItemViews] Port to non-deprecated QWheelEvent API
Summary

Unfortunately there is no QWidget::mapFromGlobal(QPointF).

Test Plan

Builds.

Diff Detail

Repository
R276 KItemViews
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16333
Build 16351: arc lint + arc unit
dfaure created this revision.Sep 10 2019, 8:00 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 10 2019, 8:00 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Sep 10 2019, 8:00 AM
dfaure updated this revision to Diff 65770.Sep 10 2019, 3:09 PM

rebase on top of Laurent's angleDelta().y() commit

mlaurent accepted this revision.Sep 10 2019, 3:41 PM

It seems ok for me. +2

This revision is now accepted and ready to land.Sep 10 2019, 3:41 PM
dfaure closed this revision.Sep 10 2019, 4:24 PM
kossebau added a subscriber: kossebau.Sep 10 2019, 4:56 PM

Seems not okay with KDE CI though ;) -> https://build.kde.org/view/Failing/job/Frameworks/job/kitemviews/

Some 5.14 API-only method now used?

dfaure added a comment.Sep 10 2019, 6:04 PM

Yep, I just spotted the CI-failure emails on k-f-d and pushed a fix.

It wasn't clear from the docs that this constructor was new. They forgot a \since ...

Revision Contents
Changeset List

Diff 65770

View Options

src/kwidgetitemdelegate.cpp

Loading...
View Options

src/kwidgetitemdelegatepool.cpp

Loading...