Apply the KDE HIG, use form layouts, make desktop files consistent and make the KCMs look better.
Details
- Reviewers
ngraham zzag - Group Reviewers
KWin Plasma VDG - Maniphest Tasks
- T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible
- Commits
- R108:663d139638b4: [kcmkwin/options] Improve the look of the KWin options KCM UIs
Open the Window Behavior KCMs. All options should still work
Diff Detail
- Repository
- R108 KWin
- Branch
- arcpatch-D23615_1
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 16166 Build 16184: arc lint + arc unit
I think the first screenshot is not up to date because "Multiscreen behavior" stuff is missing. ;-)
I don't like that the detailed description of the focus policy is effectively lost. It's quite important.
VDG decided in another thread no-one uses whatsthis, which I kinda agree with.
kcmkwin/kwinoptions/main.cpp | ||
---|---|---|
92–93 | Where does this object name get used? | |
kcmkwin/kwinoptions/mouse.cpp | ||
261 | why is this swapped? |
kcmkwin/kwinoptions/main.cpp | ||
---|---|---|
92–93 | Oops, sorry, that's not really shere it's used. I'll have to see where. |
kcmkwin/kwinoptions/main.cpp | ||
---|---|---|
92–93 | I can't see where it is used, it's probably not visible anywhere. |
I wonder if using a KMessageWidget for the description might be appropriate. KWin already does this for the Compositor KCM.
kcmkwin/kwinoptions/windows.cpp | ||
---|---|---|
351–352 | Why is it here? |
Use dynamically changing description label under combobox and remove unrelated change
kcmkwin/kwinoptions/windows.cpp | ||
---|---|---|
176 | Style: a switch statement should look like switch (foo) { case Foo: break; case Bar: break; } i.e. cases are not indented and opening brace is kept on the same line as switch keyword. |
kcmkwin/kwinoptions/main.cpp | ||
---|---|---|
92–93 | It won't be in the ui. An object name is an internal ID. Which means either its used in some code and changing it will break things....or its unused. From what I could see it happens to be unused. |
kcmkwin/kwinoptions/main.cpp | ||
---|---|---|
92–93 | Should I keep this change then? |
Cool, generally much better.
This could be further cleaned up:
kcmkwin/kwinoptions/actions.ui | ||
---|---|---|
26 | Call this "Left click action" | |
66 | Call this "Middle click action" | |
106 | Call this "Right-click action" | |
kcmkwin/kwinoptions/mouse.ui | ||
176 | Call this "Left click action" | |
199 | Call this "Middle click action" | |
212 | Call this "Right click action" |
kcmkwin/kwinoptions/actions.ui | ||
---|---|---|
26 | I'll add the word action to the group box headers instead, so the labels aren't so long and there's less duplication. |
There are still a few more instances of using "button" instead of "click" on the Window Actions tab: