Replace Wayland/XDG outputs checks with enablement checks
ClosedPublic
Actions

Authored by romangg on Aug 28 2019, 11:43 PM.

Details

Reviewers

None

Group Reviewers

KWin

Commits

Summary

Make it more explicit what the relation is between Wayland and XDG objects
existing and enablement:

The ouput is enabled if and only if Wayland and XDG output objects exist.

We can simplify the code by replacing checks on the outputs with checking
the current enablement value.

Test Plan

Wayland nested and virtual backends.

Repository

R108 KWin

Branch

enableOutputCheck

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 15818
Build 15836: arc lint + arc unit

Restricted Application added a subscriber: kwin. · View Herald Transcript

romangg requested review of this revision.Aug 28 2019, 11:43 PM

In order to not send wl_output data changes needlessly often this needs some more work on init.

Rebase on master.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 5 2019, 3:29 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			abstract_wayland_output.h (12 lines)
M			abstract_wayland_output.cpp (41 lines)
M			plugins/platforms/drm/drm_output.cpp (5 lines)
M			plugins/platforms/fbdev/fb_backend.cpp (4 lines)
M			plugins/platforms/hwcomposer/hwcomposer_backend.cpp (3 lines)
M			plugins/platforms/virtual/virtual_output.cpp (5 lines)
M			plugins/platforms/wayland/wayland_output.cpp (4 lines)
M			plugins/platforms/x11/windowed/x11windowed_output.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	64905	70ea22b		Aug 28 2019, 11:43 PM	★	★
Diff 2	64945	70ea22b	- Init Wayland output with device output	Aug 29 2019, 1:54 PM	★	★
Diff 3	64949	5f25bee	Rebase on master.	Aug 29 2019, 2:33 PM	★	★
Diff 4	65442	f7ff62e	R108:b3e7664d2cd2c8fb2335a1b218e2e4ee2f241ef6	Sep 5 2019, 3:29 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
3f644a73c508	88f619c25fbc	3730a99700f0	Roman Gilg	Init Wayland output with device output	Aug 29 2019, 1:53 PM
3730a99700f0	f46fc30dbcfa	70ea22b36fea	Roman Gilg	Replace Wayland/XDG outputs checks with enablement checks (Show More…)	Aug 28 2019, 11:37 PM

Status	Author	Revision
Closed	romangg	D23733 [kded] Save replication source hash to config file
Closed	romangg	D23666 [kcm] Provide graphical interface to replicate outputs
Closed	romangg	D22468 Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami
Closed	romangg	D23731 Wayland: Set fractional output scale
Closed	romangg	D23732 [kded] Support fractional output scale
Closed	romangg	D23663 RandR: Replicate outputs with XRender extension
Needs Review	romangg	D23662 Wayland: Support output replication
Closed	romangg	D23710 Introduce output replication API
Needs Review	romangg	D23684 WIP: Add presenting event to output-device protocol
Needs Review	romangg	D23665 [platforms/drm] Support output replication
Closed	romangg	D23600 [platforms/drm] Rework enablement and dpms switching
Closed	romangg	D23553 Replace Wayland/XDG outputs checks with enablement checks
Closed	romangg	D23545 Lift output enablement into Platform
Needs Review	romangg	D23619 Introduce cloning and replication of output devices
Abandoned	romangg	D23669 Generate mipmaps for image down-scaling