Optimize KProcessList::processInfo on unix so that it doesn't iterate over all
processes and then filter the list to the requested process. Instead refactor
the code that fetches process info from a single process and use that function.
Details
Details
Unit Test
BUG: 410945
Diff Detail
Diff Detail
- Repository
- R244 KCoreAddons
- Branch
- optimize_kprocesslist_processinfo
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 15795 Build 15813: arc lint + arc unit
Comment Actions
I've reviewed the patch and it's good, you've addressed the issues that were noted by Aleix already, so please commit and we can address anything that might pop up as it happens.
Comment Actions
This broke the build on FreeBSD - See https://build.kde.org/view/Failing/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/lastFailedBuild/console
Comment Actions
I pushed a quick fix to unbreak the build as bfdc20ed7c6fc1397ba66edd07f86c84d380e291
You might want to inspect it to add that optimization code for the procstat as well, if possible (no idea).
Comment Actions
Sorry for breaking the build :/
@kossebau - thanks for fixing it so quickly! I think your fix looks fine :D