WriterCollection was apparently never used.
It crashed upon destruction due to bogus
deletion of the writer plugins.
This carries over some code of the
ExtractorCollection and cleans up a little
bit along the way. Adds a simple test.
Details
Details
Diff Detail
Diff Detail
- Repository
- R286 KFileMetaData
- Branch
- fixWriterCollection
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 15615 Build 15633: arc lint + arc unit
src/writercollection.cpp | ||
---|---|---|
133 | No. m_plugin is either a QPluginLoader::instance(), i.e. shared, or a collection-owned ExternalWriter. |
src/writer.h | ||
---|---|---|
63 | This is only for cleanup and consistency with the corresponding extractor class. |
Comment Actions
friendly ping. Since this solves a crash and I want to start using the writers in Elisa, I would like to have it rather sooner in a frameworks release and I'm away the next weeks
Comment Actions
The test incorrectly fails when a user builds kfilemetadata without taglib
collection.fetchWriters(QStringLiteral("audio/mpeg3")).isEmpty() would be true in that case