Differential D23361

Adding a modulo operator to the AlkValue class to avoid using gmp in kmymoney
ClosedPublic
Actions

Authored by habacker on Aug 22 2019, 8:24 PM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

R471:99e114cd8c3c: Adding a modulo operator to the AlkValue class to avoid using gmp in kmymoney

Summary

See https://cgit.kde.org/kmymoney.git/tree/kmymoney/mymoney/payeeidentifier/ibanbic/ibanbic.cpp?h=5.0#n259

Test Plan

compiled on linux

Diff Detail

Repository

R471 Alkimia Library

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 15519
Build 15537: arc lint + arc unit

habacker requested review of this revision.Aug 22 2019, 8:24 PM

habacker created this revision.

Harbormaster completed remote builds in B15504: Diff 64354.Aug 22 2019, 8:24 PM

Other than that it looks ok to me.

src/alkvalue.h.in
200	Why don't you retrun an AlkValue here? It would seem more natural to me here, even though not used in your use case. But it does not hurt either.

This revision now requires changes to proceed.Aug 23 2019, 6:21 AM

return AlkValue

Harbormaster completed remote builds in B15519: Diff 64391.Aug 23 2019, 6:42 AM

tbaumgart accepted this revision.Aug 23 2019, 6:49 AM

This revision is now accepted and ready to land.Aug 23 2019, 6:49 AM

Closed by commit R471:99e114cd8c3c: Adding a modulo operator to the AlkValue class to avoid using gmp in kmymoney (authored by habacker). · Explain WhyAug 23 2019, 7:52 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/alkvaluetest.h (1 line)
M			autotests/alkvaluetest.cpp (11 lines)
M			src/alkvalue.h.in (1 line)
M			src/alkvalue.cpp (8 lines)

Diff 64391

autotests/alkvaluetest.h

Loading...

autotests/alkvaluetest.cpp

Loading...

src/alkvalue.h.in

Loading...

src/alkvalue.cpp

Loading...