Make it possible to modify contacts
AbandonedPublic

Authored by apol on Aug 6 2019, 2:07 PM.

Details

Summary

Includes a vcard field so that backends can feed all of the data through
it.
Introduces the AbstractEditableContact that when subclassed it will be
able to edit contacts by overriding setCustomProperty.
The vcard was introduced because I'd expect contact applications using
the vcard data as an interface rather than implementing every property
one by one.

Test Plan

Modified my contacts several times using plasma-phonebook.

Diff Detail

Repository
R307 KPeople
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15484
Build 15502: arc lint + arc unit
apol created this revision.Aug 6 2019, 2:07 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 6 2019, 2:07 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Aug 6 2019, 2:07 PM
apol updated this revision to Diff 64314.Aug 22 2019, 3:39 PM

Make it possible to create new contacts

apol updated this revision to Diff 64325.Aug 22 2019, 4:47 PM

Fix JBB's crash

bshah requested changes to this revision.Aug 23 2019, 4:22 PM
bshah added inline comments.
src/backends/abstracteditablecontact.h
31

Since 5.62

src/persondata.h
103

Missing API docs

126

Missing API doc

This revision now requires changes to proceed.Aug 23 2019, 4:22 PM
apol marked 3 inline comments as done.Aug 28 2019, 12:37 PM
apol updated this revision to Diff 64834.Aug 28 2019, 12:37 PM

Address Bhushan's comments

jbbgameich added inline comments.Aug 29 2019, 4:04 PM
src/declarative/peopleqmlplugin.cpp
64

Not sure whether this should follow the Person(s) naming scheme as well..

apol updated this revision to Diff 64963.Aug 29 2019, 6:53 PM

Don't get creative naming classes on the qml plugin

apol marked an inline comment as done.Aug 29 2019, 6:53 PM
jbbgameich accepted this revision.Aug 30 2019, 9:51 PM
apol abandoned this revision.Sep 2 2019, 11:59 PM