| zzag |
| KWin |
Aurorae has a timer between request update and updating the contents.
This makes some sense.
However on initial creation we want to snap the contents immediately as
otherwise we may be out by a frame between a new window being mapped and
the window decoration being rendered.
Ran with Auroae
Windows opened immediately seemed to have a deco straight away
| Lint OK |
| No Unit Test Coverage |
| Buildable 15481 | |
| Build 15499: arc lint + arc unit |
The only possible regression could be some implicit assumption somewhere that this will be handled in the event loop. I had this problem with my compositing work and had to do a QTimer::singleShot with 0 duration (otherwise segfaulted somewhere in Effects system). You think this can't be a problem here?
From a QtQuick POV, I can be fairly confident everything will be fine.
On the Kwin side, its already evaluating the bindings at this point, so I don't envision anything that could crash - at most we'll trigger a repaint which isn't much worse than the current state.
I did give it a bit of a test on a range of decos and actions.
| plugins/kdecorations/aurorae/src/aurorae.cpp | ||
|---|---|---|
| 375 | We can't do this here because m_view hasn't been resized yet. Color attachment is considered to be incomplete if its width or height is less than 1. https://gitlab.freedesktop.org/mesa/mesa/blob/master/src/mesa/main/fbobject.c#L856 | |
Heh, on lovely nvidia that doesn't cause an issue
Extra testing done:
| plugins/kdecorations/aurorae/src/aurorae.cpp | ||
|---|---|---|
| 610–640 | Indent this code with 4 spaces, rather than 8. | |