Differential D23266

Export Plasma core lib log category, add a category to a qWarning
ClosedPublic
Actions

Authored by meven on Aug 19 2019, 2:50 PM.

Details

Reviewers
broulik
davidedmundson
apol
Group Reviewers
Frameworks
Commits
R242:5f6996ee50f8: Export Plasma core lib log category, add a category to a qWarning
Test Plan

Builds, new context for warning is visible

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
arcpatch-D23266
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15311
Build 15329: arc lint + arc unit
meven created this revision.Aug 19 2019, 2:50 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 19 2019, 2:50 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Aug 19 2019, 2:50 PM
apol added a subscriber: apol.Aug 19 2019, 5:00 PM

How about porting it to use ecm_qt_declare_logging_category?

CMakeLists.txt
226

This is not necessary, ECM and Plasma Framework are released together.

meven updated this revision to Diff 64060.Aug 19 2019, 6:19 PM

Add Plasma quick lib category, avoid ECM_VERSION check

meven added a comment.Aug 19 2019, 6:21 PM
In D23266#514605, @apol wrote:

How about porting it to use ecm_qt_declare_logging_category?

I don't see what you mean, there are already two build target that uses ecm_qt_declare_logging_category in this repo.
Am missing something ?

davidedmundson accepted this revision.Oct 3 2019, 5:01 PM
This revision is now accepted and ready to land.Oct 3 2019, 5:01 PM
apol accepted this revision.Oct 3 2019, 7:08 PM

Go for it, can change later too.

Closed by commit R242:5f6996ee50f8: Export Plasma core lib log category, add a category to a qWarning (authored by meven). · Explain WhyOct 4 2019, 7:14 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
AMplasma-framework.categories (2 lines)
Msrc/plasma/pluginloader.cpp (2 lines)

Diff 64060

View Options

CMakeLists.txt

Loading...
View Options

plasma-framework.categories

Loading...
View Options

src/plasma/pluginloader.cpp

Loading...