Differential D22931

Safer MachineInfo Key Reads
ClosedPublic
Actions

Authored by rizzitello on Aug 4 2019, 4:14 PM.

Details

Reviewers
laysrodrigues
tcanabrava
patrickelectric
Commits
R232:994632ead01b: Safer MachineInfo Key Reads
Summary

Safer MachineInfo Key Reads

Diff Detail

Branch
saferMachineInfoRead
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15266
Build 15284: arc lint + arc unit
rizzitello requested review of this revision.Aug 4 2019, 4:14 PM
rizzitello created this revision.
patrickelectric added inline comments.Aug 5 2019, 11:37 AM
src/core/machineinfo.cpp
132

Are you sure that is <= with .side() ?

rizzitello updated this revision to Diff 63112.Aug 5 2019, 11:51 AM

update all calls use correct range

rizzitello marked an inline comment as done.Aug 5 2019, 11:51 AM
patrickelectric accepted this revision.Aug 5 2019, 11:52 AM
This revision is now accepted and ready to land.Aug 5 2019, 11:52 AM
laysrodrigues accepted this revision.Aug 18 2019, 8:03 PM
Closed by commit R232:994632ead01b: Safer MachineInfo Key Reads (authored by rizzitello). · Explain WhyAug 18 2019, 8:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/machineinfo.cpp (6 lines)

Diff 63991

View Options

src/core/machineinfo.cpp

Loading...