Differential D23229

KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables
ClosedPublic
Actions

Authored by asturmlechner on Aug 17 2019, 9:05 PM.

Details

Reviewers
ltoscano
Group Reviewers
Frameworks
Commits
R238:0c073ecebbb1: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables
Summary

HTML_INSTALL_DIR -> KDE_INSTALL_DOCBUNDLEDIR
MAN_INSTALL_DIR -> KDE_INSTALL_MANDIR

BUG: 410998

Test Plan

Install paths are correct by example of marble.

Diff Detail

Repository
R238 KDocTools
Branch
kdeinstalldirs
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15242
Build 15260: arc lint + arc unit
asturmlechner created this revision.Aug 17 2019, 9:05 PM
Restricted Application added projects: Frameworks, Documentation. · View Herald TranscriptAug 17 2019, 9:05 PM
Restricted Application added subscribers: kde-doc-english, kde-frameworks-devel. · View Herald Transcript
asturmlechner requested review of this revision.Aug 17 2019, 9:05 PM
ltoscano added a subscriber: ltoscano.Aug 17 2019, 9:19 PM

I can't check now, but I think the case were "the deprecated variable is set, but the new one is not, then the old one is used" should be considered.

KF5DocToolsMacros.cmake
236

I wonder if we should consider the deprecated variable as well. It's deprecated, but if it has been set, and the new one is not set, the old one should be probably used.

243

Aee above.

asturmlechner updated this revision to Diff 63954.Aug 17 2019, 9:49 PM

Use deprecated variables as fallback if defined

asturmlechner marked 2 inline comments as done.Aug 26 2019, 5:33 AM
ltoscano accepted this revision.Aug 26 2019, 9:26 AM

(sorry, time off) thanks!

This revision is now accepted and ready to land.Aug 26 2019, 9:26 AM
asturmlechner closed this revision.Aug 26 2019, 1:02 PM

Revision Contents
Changeset List

PathPackages
MKF5DocToolsMacros.cmake (30 lines)

Diff 63954

View Options

KF5DocToolsMacros.cmake

Loading...