Differential D23007

Add expanding space between grid delegates as window is resized
ClosedPublic
Actions

Authored by ngraham on Aug 7 2019, 5:37 PM.

Details

Reviewers
mgallien
astippich
Group Reviewers
Elisa
VDG
Commits
R255:ffc043fda605: Add expanding space between grid delegates as window is resized
Test Plan

Diff Detail

Repository
R255 Elisa
Branch
add-expanding-space-between-grid-delegates (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15107
Build 15125: arc lint + arc unit
ngraham requested review of this revision.Aug 7 2019, 5:37 PM
ngraham created this revision.
astippich added a comment.Aug 14 2019, 5:48 PM

Sorry, overlooked this one.
I quite like the behavior, but why do you limit it to 3 minimum items? This prohibits scaling the window to a small size and actually makes them items overlapped when forcing it into one corner of the screen.

ngraham updated this revision to Diff 63752.Aug 14 2019, 6:01 PM

Minimum number of columns is two, not three

astippich accepted this revision.Aug 14 2019, 6:27 PM
This revision is now accepted and ready to land.Aug 14 2019, 6:27 PM
Closed by commit R255:ffc043fda605: Add expanding space between grid delegates as window is resized (authored by ngraham). · Explain WhyAug 14 2019, 8:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/qml/GridBrowserView.qml (6 lines)

Diff 63752

View Options

src/qml/GridBrowserView.qml

Loading...