| gottfried |
Fix some visual glitches in dark themes, like Breeze Dark.
Now, the LearningProgressChart respects the user's preferences and
uses the background and text color from the theme.
The InformationTable of the user profile now uses the theme's color
to show the data.
Before:
| Lint Skipped |
| Unit Tests Skipped |
| src/qml/common/InformationTable.qml | ||
|---|---|---|
| 28 | Please remove all trailing whitespace. | |
| 29 | Please use KColorScheme instead of SystemPalette for color scheme colors. Most of KTouch uses the former now. It has some features like complementary colors SystemPalette lacks. | |
| src/qml/common/LearningProgressChart.qml | ||
| 110 ↗ | (On Diff #63416) | This is not related to colors. |
| src/qml/homescreen/StatPopupDialog.qml | ||
| 46 | See above. | |
| src/qml/scorescreen/ScoreScreen.qml | ||
| 110 | See above. | |
| 342 | This change is not necessary. The legend followed to the color scheme before, too. | |
| 351 | This change is not necessary. The legend followed to the color scheme before, too. | |
| 378 | Please use KColorScheme instead. | |
Hello.
Thanks for the review. I have changed SystemPalette to KColorSheme. Sorry for the change of the width, but in Spanish the translation is too long for the popup, in my opinion.
This may be off of topic, but should we make bigger the popup?
Thanks for the update!
This may be off of topic, but should we make bigger the popup?
I see. Yes you can, but please in its own commit. This (and the changes here) should go into the Applications/19.08 branch.
This (and the changes here) should go into the Applications/19.08 branch
I'm new to contribute to KDE. Is this done automatically or I need to do something else?
With Phabricator, an automatic merge is not possible, unfortunately. It can only do code review.
To push the changes yourself, you need to have a developer account. If you want to continue with KDE development, you should apply sooner or later. In the mean time, I can push the changes for you.