Differential D23071

Remove usage of QWeakPointer for QObject for AbstractThumbnailItem::m_parent
ClosedPublic
Actions

Authored by gladhorn on Aug 10 2019, 10:16 AM.

Details

Reviewers
zzag
romangg
Group Reviewers
KWin
Commits
R108:00daa8a07e3c: Remove usage of QWeakPointer for QObject for AbstractThumbnailItem::m_parent
Summary

This usage of QWeakPointer has been deprecated since Qt 5.0, since it
leads to really confusing API - usually you must never dereference a
QWeakPointer directly, but always go through QSharedPointer, except in
this one case, where it's permissible.

Use QPointer instead, which is clean.

Diff Detail

Repository
R108 KWin
Branch
arcpatch-D23071
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 14947
Build 14965: arc lint + arc unit
gladhorn created this revision.Aug 10 2019, 10:16 AM
Restricted Application added a project: KWin. · View Herald TranscriptAug 10 2019, 10:16 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
gladhorn requested review of this revision.Aug 10 2019, 10:16 AM
zzag accepted this revision.Aug 10 2019, 10:37 AM
This revision is now accepted and ready to land.Aug 10 2019, 10:37 AM
romangg requested changes to this revision.Aug 10 2019, 10:37 AM
This revision now requires changes to proceed.Aug 10 2019, 10:37 AM
romangg added a comment.Aug 10 2019, 10:40 AM

Sorry, was just to write a commet on the other patch about the names of the commits and missing (?) part 1. See https://phabricator.kde.org/D23070#509746

gladhorn updated this revision to Diff 63474.Aug 10 2019, 10:53 AM
gladhorn retitled this revision from Remove usage of QWeakPointer for QObject part 3 to Remove usage of QWeakPointer for QObject for AbstractThumbnailItem::m_parent.

Improve commit message

gladhorn updated this revision to Diff 63475.Aug 10 2019, 11:30 AM
gladhorn edited the summary of this revision. (Show Details)

improve commit message

romangg accepted this revision.Aug 10 2019, 12:33 PM
This revision is now accepted and ready to land.Aug 10 2019, 12:33 PM
Closed by commit R108:00daa8a07e3c: Remove usage of QWeakPointer for QObject for AbstractThumbnailItem::m_parent (authored by gladhorn). · Explain WhyAug 10 2019, 2:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mthumbnailitem.h (2 lines)
Mthumbnailitem.cpp (11 lines)

Diff 63475

View Options

thumbnailitem.h

Loading...
View Options

thumbnailitem.cpp

Loading...