Differential D23052

[Sidebar] Use new Kirigami ListSectionHeader component
ClosedPublic
Actions

Authored by ngraham on Aug 9 2019, 4:44 PM.

Details

Reviewers
GB_2
Group Reviewers
Plasma
VDG
Maniphest Tasks
T10384: Unify styles for lists and their buttons
Commits
R124:34ee0e8f6d7f: [Sidebar] Use new Kirigami ListSectionHeader component
Summary

This allows all the section headers to always have the same look and feel and be
adjusted in just one place.

Depends on D23049

Test Plan

Diff Detail

Repository
R124 System Settings
Branch
use-new-kirigami-section-header (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14918
Build 14936: arc lint + arc unit
ngraham created this revision.Aug 9 2019, 4:44 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 9 2019, 4:44 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Aug 9 2019, 4:44 PM
GB_2 accepted this revision as: VDG, GB_2.Aug 9 2019, 4:45 PM
This revision is now accepted and ready to land.Aug 9 2019, 4:45 PM
ngraham added a comment.Sep 5 2019, 4:13 PM

I'm going to land all these patches after Frameworks 5.62 has branched (in two days) to prevent the builds from failing until then due to new stricter ECM frameworks-version-finding behavior.

Closed by commit R124:34ee0e8f6d7f: [Sidebar] Use new Kirigami ListSectionHeader component (authored by ngraham). · Explain WhySep 8 2019, 2:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 63433

View Options

CMakeLists.txt

Loading...
View Options

sidebar/package/contents/ui/CategoriesPage.qml

Loading...
View Options

sidebar/package/contents/ui/SubCategoryPage.qml

Loading...