Differential D22904

Fix bookmark action
ClosedPublic
Actions

Authored by jbbgameich on Aug 2 2019, 9:21 PM.

Details

Reviewers
ngraham
Group Reviewers
Okular
Plasma: Mobile
Commits
R223:cff01c1063cd: Fix bookmark action
Summary

Adds tootip, different icons depending on checked state and fixed functionality

Test Plan
  • Open a document
  • click bookmark action
  • the bookmarked page should appear in the bookmarks tab of the contextDrawer

Diff Detail

Repository
R223 Okular
Branch
fix-bookmark
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14698
Build 14716: arc lint + arc unit
jbbgameich created this revision.Aug 2 2019, 9:21 PM
Restricted Application added a project: Okular. · View Herald TranscriptAug 2 2019, 9:21 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
jbbgameich requested review of this revision.Aug 2 2019, 9:21 PM
ngraham added a subscriber: ngraham.Aug 2 2019, 9:22 PM
ngraham added inline comments.
mobile/app/package/contents/ui/MainView.qml
36

Capitalize the first letters of each tooltip; tooltips use sentence-style capitalization

jbbgameich updated this revision to Diff 63005.Aug 2 2019, 9:23 PM

Use non-abstract application window, fixes Kirigami Action Button

jbbgameich updated this revision to Diff 63006.Aug 2 2019, 9:24 PM

Capitalize the first letters of each tooltip

ngraham accepted this revision.Aug 3 2019, 1:40 AM
This revision is now accepted and ready to land.Aug 3 2019, 1:40 AM
jbbgameich closed this revision.Aug 3 2019, 7:48 AM

Revision Contents
Changeset List

Diff 63006

View Options

mobile/app/package/contents/ui/MainView.qml

Loading...
View Options

mobile/app/package/contents/ui/main.qml

Loading...