Convert colors into GTK colordefs
ClosedPublic

Authored by cblack on Aug 1 2019, 3:31 PM.

Details

Summary

All of the colors pulled from a colorscheme in Breeze GTK now use GTK's color definitons, allowing them to be changed without recompiling the theme.
GTK18 and GTK20 have been merged as well, lessening work required to make changes & maintain.
There are some other minor changes (radio buttons/checkboxes now sink in when clicking as their Qt counterparts do.)
The varaible $new-highlight has been added to gtk.scss. Toggling it to true will cause the highlights to resemble ndavis/highlight @ Breeze. Added that because I had already made the changes to the theme when I did the colordefs, and I don't want to wait on the new highlight style to be set in stone before this can be merged.

One caveat - checkboxes and radiobuttons are hardcoded at build time because they're PNGs. However, the design trend in GNOME applications is to move away from checkboxes and radiobuttons, and they're relatively minor in the grand scheme of things. Redoing them somehow is most likely out of the scope of this revision.

Test Plan

See that the theme works as intended with GTK color definitions.

Diff Detail

Branch
color-defs (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14689
Build 14707: arc lint + arc unit
cblack requested review of this revision.Aug 1 2019, 3:31 PM
cblack created this revision.
ngraham added a subscriber: ngraham.Aug 1 2019, 3:45 PM

There are some other minor changes (radio buttons/checkboxes now sink in when clicking as their Qt counterparts do.)

Let's do that in a separate patch first. Seems like a good idea regardless of how this change goes.

cblack updated this revision to Diff 62932.Aug 1 2019, 8:04 PM

Spin out pressed buttons into own diff

Needs a rebase.

cblack updated this revision to Diff 62994.Aug 2 2019, 5:07 PM

Hoped that rebase worked

cblack updated this revision to Diff 62995.Aug 2 2019, 5:17 PM

Perhaps git is more cooperative now?

cblack updated this revision to Diff 62996.Aug 2 2019, 5:35 PM

Hopefully that should rebase onto master properly now

cblack updated this revision to Diff 62997.Aug 2 2019, 5:43 PM

Resolve merge conflicts?

cblack updated this revision to Diff 62998.Aug 2 2019, 5:52 PM

Probably not going to work, but here's another attempt at rebasing

cblack updated this revision to Diff 63000.Aug 2 2019, 6:26 PM

Hopefully it should be properly working now. Hopefully.

ngraham accepted this revision.Aug 2 2019, 8:31 PM

This is really excellent work.

src/_colors.scss
27

decoation? :)

This revision is now accepted and ready to land.Aug 2 2019, 8:31 PM
cblack updated this revision to Diff 63002.Aug 2 2019, 8:43 PM

Typos, begone

ngraham retitled this revision from [Breeze GTK] - Convert colors into GTK colordefs to Convert colors into GTK colordefs.Aug 6 2019, 3:01 PM
This revision was automatically updated to reflect the committed changes.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 6 2019, 3:04 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham edited the summary of this revision. (Show Details)Aug 6 2019, 3:04 PM
ngraham edited the summary of this revision. (Show Details)