Julia backend: build fixes
ClosedPublic

Authored by ivanlakhtanov on Aug 25 2016, 11:34 AM.

Details

Summary

Added FindJulia.cmake + changes in other cmake files

Diff Detail

Repository
R55 Cantor
Lint
Lint Skipped
Unit
Unit Tests Skipped
ivanlakhtanov retitled this revision from to Julia backend: build fixes.
ivanlakhtanov updated this object.
ivanlakhtanov edited the test plan for this revision. (Show Details)
ivanlakhtanov set the repository for this revision to R55 Cantor.
ivanlakhtanov added subscribers: Cantor, filipesaraiva, cfeck.
cfeck added a comment.Aug 25 2016, 2:10 PM

Could you please state which license the copied file has?

Forget to change linking name in julia-server

Link on the top of the file was wrong

In D2575#48143, @cfeck wrote:

Could you please state which license the copied file has?

Here is the link (it's mentioned on the top of the file, was wrong before):
https://gist.github.com/JayKickliter/06d0e7c4f84ef7ccc7a9

I don't know which license it is: it's not mentioned in the gist. I don't have github account to send a message. Maybe you can ask him?

filipesaraiva edited edge metadata.Aug 25 2016, 3:31 PM

In D2575#48183, @ivanlakhtanov wrote:
I don't know which license it is: it's not mentioned in the gist. I don't have github account to send a message. Maybe you can ask him?

I asked him, let's wait for the reply.

I sent an e-mail to Jay Kickliter (the original author of this code) some days ago, let's wait more days for some reply.

If he doesn't answer us let's think about some way to use his code (or something based in his code) in Cantor.

@ivanlakhtanov, I think the original developer doesn't want to help us with this...

Well, please could you give a look in this other approach? This code uses MIT license, so we can use it without problem if it works.

@ivanlakhtanov, I think the original developer doesn't want to help us with this...

Well, please could you give a look in this other approach? This code uses MIT license, so we can use it without problem if it works.

I will be available to manage with this at the weekend. Is it OK? Maybe I will make own implementation.

No problem Ivan, go ahead.

ivanlakhtanov edited edge metadata.
ivanlakhtanov added a project: Cantor.

New implementation of FindJulia.cmake

  • Latest discussed implementation is almost similar with one I've found before.
  • I've made own one (of course with some stuff from known implementations, because it seems there is no way to implement another way)
filipesaraiva accepted this revision.Sep 19 2016, 5:16 PM
filipesaraiva edited edge metadata.

Nice @ivanlakhtanov, please push it!
Add the special keywords Differential Review and Bug: 368986.

This revision is now accepted and ready to land.Sep 19 2016, 5:16 PM
This revision was automatically updated to reflect the committed changes.