Sync scaling DPI from Plasma to SDDM
ClosedPublic
Actions

Authored by filipf on Jul 23 2019, 8:48 PM.

Details

Reviewers

davidedmundson
ngraham

Group Reviewers

Plasma

Commits

R123:f909a8ab0ea3: Sync scaling DPI from Plasma to SDDM

Summary

This patch adds scaling to the list of Plasma settings that can be synced with SDDM.

Test Plan

Displays->Scale Display->set to 1.5
Login Screen(SDDM)->Advanced->pressed "Sync"
SDDM was big.

Diff Detail

Repository

R123 SDDM Configuration Panel (KCM)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

filipf created this revision.Jul 23 2019, 8:48 PM

Restricted Application added a project: Plasma. · View Herald TranscriptJul 23 2019, 8:48 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

filipf requested review of this revision.Jul 23 2019, 8:48 PM

Harbormaster completed remote builds in B14349: Diff 62439.Jul 23 2019, 8:48 PM

filipf edited the test plan for this revision. (Show Details)Jul 23 2019, 8:50 PM

filipf added reviewers: Plasma, davidedmundson, ngraham.

davidedmundson accepted this revision.Jul 23 2019, 9:58 PM

This revision is now accepted and ready to land.Jul 23 2019, 9:58 PM

👍 👍

Closed by commit R123:f909a8ab0ea3: Sync scaling DPI from Plasma to SDDM (authored by filipf). · Explain WhyJul 24 2019, 7:34 AM

This revision was automatically updated to reflect the committed changes.

One potentially major issue that if I'm right needs fixing ASAP

src/advanceconfig.cpp
156	What are you going to write if this entry is missing? I suspect you'll write just "-dpi " into ServerArguments and then X11 will run with "X11 -dpi" expect another argument and simply fail to load?
157	As a coding note it's useful to make sure the data in the variables matches their name. In this case "dpiValue" isn't just the DPI value, it's a string formatted as X server arguments "-dpi" here. So I would suggest either renaming or (probably easier with the other fix) adding the "-dpi "prefix when you insert it into the map.

I believe you're right. Let me know if this is a good fix: https://cgit.kde.org/sddm-kcm.git/commit/?id=a48e07c8156a10a7519f18ec72a9608fc5bfaa0a

fix of the fix: https://cgit.kde.org/sddm-kcm.git/commit/?id=93fe6410f0f258237a12a4f3bbba0ebfbce25dad

When I press the synchronize button, it looks like the -dpi 144 (scale x1.5) option makes the UI elements huge (feel like x2 scale or more):

In D22700#662134, @guoyunhe wrote:

When I press the synchronize button, it looks like the -dpi 144 (scale x1.5) option makes the UI elements huge (feel like x2 scale or more):

-dpi 144 works the same for me in Plasma and SDDM, but do file a bug under systemsettings->kcm_sddm and copy paste what you have in /etc/sddm.conf.d/kde_settings.conf. I'll investigate.

In D22700#662323, @filipf wrote:

In D22700#662134, @guoyunhe wrote:

When I press the synchronize button, it looks like the -dpi 144 (scale x1.5) option makes the UI elements huge (feel like x2 scale or more):

-dpi 144 works the same for me in Plasma and SDDM, but do file a bug under systemsettings->kcm_sddm and copy paste what you have in /etc/sddm.conf.d/kde_settings.conf. I'll investigate.

I think it is more likely an SDDM issue, because its document says so and the issue can be reproduced without using kcm_sddm. So I reported it here https://github.com/sddm/sddm/issues/1253