Change Highlight to ButtonFocus in stylesheets
ClosedPublic

Authored by ndavis on Jul 22 2019, 1:56 PM.

Details

Summary

This fixes an issue where changing the selection background color in the colorscheme also changes the color of SVG elements using Highlight. This also prevents the elements from blending in with the selection background in colorschemes that use a different color for selection than the focus decoration.

Test Plan

Before:
The blue SVG element blends in with the selection background.

After:
In this screenshot, a darker blue is used for the selection background and a lighter blue is used for focus decorations. The icons use the focus decoration color.

Diff Detail

Repository
R266 Breeze Icons
Branch
focus-color (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14269
Build 14287: arc lint + arc unit
ndavis created this revision.Jul 22 2019, 1:56 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 22 2019, 1:56 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Jul 22 2019, 1:56 PM
ndavis edited the test plan for this revision. (Show Details)Jul 22 2019, 1:59 PM
ndavis updated this revision to Diff 62303.Jul 22 2019, 2:04 PM

Change ViewFocus to ButtonFocus to match some elements in the Breeze desktop theme

ndavis retitled this revision from Change Highlight to ViewFocus in stylesheets to Change Highlight to ButtonFocus in stylesheets.Jul 22 2019, 2:04 PM
ngraham accepted this revision.Jul 22 2019, 2:08 PM
ngraham added a subscriber: ngraham.

Whoa, huge diff. All the more reason why we need to find a way to have all the icons use a single external stylesheet.

This will require documentation changes as well on https://hig.kde.org/style/icon.html and https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips

As for the change itself, this is what happens when using the light color scheme:

Seems like this change just shifts the problem from Breeze Dark to regular Breeze.

This revision is now accepted and ready to land.Jul 22 2019, 2:08 PM
ngraham requested changes to this revision.Jul 22 2019, 2:09 PM
This revision now requires changes to proceed.Jul 22 2019, 2:09 PM
ndavis added a comment.EditedJul 22 2019, 2:19 PM

Whoa, huge diff. All the more reason why we need to find a way to have all the icons use a single external stylesheet.

This will require documentation changes as well on https://hig.kde.org/style/icon.html and https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips

As for the change itself, this is what happens when using the light color scheme:

Seems like this change just shifts the problem from Breeze Dark to regular Breeze.

Actually, the problem isn't shifted at all, the change just doesn't fix anything for the current versions of Breeze and Breeze Dark. I'm using a custom colorscheme that reflects how I want Breeze Dark to look in the future. Breeze will use colors like these in the future:

Right, I see that there's actually no regression. In principle, can you describe what a color scheme needs to do to avoid this situation?

Right, I see that there's actually no regression. In principle, can you describe what a color scheme needs to do to avoid this situation?

Use a selection background color that is different from the button focus decoration color.

ngraham accepted this revision.Jul 22 2019, 3:50 PM

Yeah, and that seems like a sensible practice in general. All right, ship it!

This revision is now accepted and ready to land.Jul 22 2019, 3:50 PM
This revision was automatically updated to reflect the committed changes.