[RFC] Also animate the Cancel button
ClosedPublic
Actions

Authored by davidre on Jul 8 2019, 1:32 PM.

Details

Reviewers

broulik
mart
ngraham

Group Reviewers

Spectacle
VDG

Commits

R166:1c92fa091384: [RFC] Also animate the Cancel button

Summary

Adds a new class ProgressButton which is a ToolButton that displays the
screenshot delay. This is achieved by first painting the button, then
a smaller transparent button on top. The width of this overlay is proportional
to the elapsed time and the color is provided by KColorScheme::PositiveText.
Finally the icon and text are drawn on top.

Test Plan

Diff Detail

Repository

R166 Spectacle

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidre created this revision.Jul 8 2019, 1:32 PM

Restricted Application added a project: Spectacle. · View Herald TranscriptJul 8 2019, 1:32 PM

Restricted Application added a subscriber: Spectacle. · View Herald Transcript

davidre requested review of this revision.Jul 8 2019, 1:32 PM

Harbormaster completed remote builds in B13702: Diff 61339.Jul 8 2019, 1:32 PM

davidre added a dependency: D22234: Change the screenshot button to cancel during the timeout.Jul 8 2019, 1:32 PM

davidre edited the test plan for this revision. (Show Details)Jul 8 2019, 1:41 PM

davidre added reviewers: Spectacle, broulik.

davidre edited the summary of this revision. (Show Details)Jul 8 2019, 1:49 PM

With MS Windows 9x as widget style the Button is missing it's border.

davidre added a reviewer: mart.Jul 8 2019, 1:57 PM

davidre added a reviewer: VDG.Jul 8 2019, 2:53 PM

Re that missing border, you're not painting CE_PushButtonBevel

src/Gui/ProgressButton.cpp
49	`qFuzzyIsNull`
src/Gui/ProgressButton.h
3	:)

However, this is a QToolButton, so this is probably to be expected.

remove autogenerated line in license and superfluous NoPen call
Draw the button raised

Harbormaster completed remote builds in B13739: Diff 61399.Jul 9 2019, 10:02 AM

MS Windows style only draws the border if the state of the toolbutton is raised. This is different compared to the other tyles I checked which draw them exactly the same for None, Enabled and Raised.

davidre edited the test plan for this revision. (Show Details)Jul 9 2019, 10:14 AM

fuzzyisnull

Harbormaster completed remote builds in B13740: Diff 61400.Jul 9 2019, 10:21 AM

Would love to have more feedback on this

I think it looks pretty cool!

Looks great and works great. Nice clean code too. Given that we're branched for 19.08, let's land this on master so we'll have a ton of time to tweak it if necessary.

This revision is now accepted and ready to land.Jul 19 2019, 6:26 PM

Closed by commit R166:1c92fa091384: [RFC] Also animate the Cancel button (authored by davidre). · Explain WhyJul 20 2019, 8:11 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/CMakeLists.txt (1 line)
M		src/Gui/KSMainWindow.cpp (2 lines)
M		src/Gui/KSWidget.h (6 lines)
M		src/Gui/KSWidget.cpp (10 lines)
A	M	src/Gui/ProgressButton.h (41 lines)
A	M	src/Gui/ProgressButton.cpp (74 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	61339	d5e7cda		Jul 8 2019, 1:32 PM	★	★
Diff 2	61399	d5e7cda	- remove autogenerated line in license and superfluous NoPen call	Jul 9 2019, 10:02 AM	★	★
Diff 3	61400	d5e7cda	- fuzzyisnull	Jul 9 2019, 10:21 AM	★	★
Diff 4	62099	49f0e96	R166:1c92fa0913843b0bba7b660939347aefb6daa6de	Jul 20 2019, 8:04 AM	★	★