Differential D22558

Merge lib/libexec/kf5 with Contents/MacOS to fix kioslave missing
ClosedPublic
Actions

Authored by Inoki on Jul 19 2019, 11:55 AM.

Details

Reviewers
vonreth
Group Reviewers
Craft
Summary

This action will import these files:

kioexec                kconf_update           kioslave
kconfig_compiler_kf5   kio_http_cache_cleaner kpac_dhcp_helper
kdeconnect-cli         kiod5                  ksendbugmail

It will not prolong too much the time of packing, because all their deps should have been copied.
Should we only copy kioslave?

Diff Detail

Repository
R138 Craft
Lint
Lint Skipped
Unit
Unit Tests Skipped
Inoki requested review of this revision.Jul 19 2019, 11:55 AM
Inoki created this revision.
vonreth accepted this revision.Jul 19 2019, 12:36 PM

sounds good

This revision is now accepted and ready to land.Jul 19 2019, 12:36 PM
Inoki updated this revision to Diff 62062.Jul 19 2019, 2:46 PM

Just copy the kioslave

vonreth added a comment.Jul 19 2019, 3:38 PM

Wouldn't the same not apply for others too?

Inoki added a comment.Jul 19 2019, 4:36 PM
In D22558#498042, @vonreth wrote:

Wouldn't the same not apply for others too?

Others may not be frequently used, AFAIK

vonreth added a comment.Jul 19 2019, 5:46 PM

Then they should be blacklisted. But if that's the right destination for those services they should all be moved.

Inoki added a comment.Jul 19 2019, 5:49 PM
In D22558#498087, @vonreth wrote:

Then they should be blacklisted. But if that's the right destination for those services they should all be moved.

Yes, it's the right place. Otherwise their deps will not be rightly fixed.

So we just copy all of them

Inoki updated this revision to Diff 62070.Jul 19 2019, 5:57 PM
vonreth accepted this revision.Jul 20 2019, 10:03 AM
Inoki planned changes to this revision.Jul 21 2019, 10:21 AM
In D22558#499049, @vonreth wrote:

I think that change had some unforseen effects https://binary-factory.kde.org/job/Dolphin_Release_macos/498/console

Yes, a filesharelist softlink to fileshareset is also imported...

How about just copying kioslave to avoid such effect?

vonreth added a comment.Jul 21 2019, 10:23 AM
In D22558#499058, @Inoki wrote:
In D22558#499049, @vonreth wrote:

I think that change had some unforseen effects https://binary-factory.kde.org/job/Dolphin_Release_macos/498/console

Yes, a filesharelist softlink to fileshareset is also imported...

How about just copying kioslave to avoid such effect?

As a fix up, its ok.

Ill investigate for the other stuff

Inoki requested review of this revision.Jul 21 2019, 10:35 AM

I'll firstly do a quick fix

This revision is now accepted and ready to land.Jul 21 2019, 10:35 AM
Inoki updated this revision to Diff 62177.Jul 21 2019, 10:36 AM
Inoki closed this revision.Jul 21 2019, 11:38 AM

Revision Contents
Changeset List

PathPackages
Mbin/Packager/MacDMGPackager.py (1 line)

Diff 62070

View Options

bin/Packager/MacDMGPackager.py

Loading...