By not checking the return of runJob(), the slave might call finished() after already having called error() in handleError().
See T7995 for futher information.
Details
Details
Diff Detail
Diff Detail
- Repository
- R219 KIO GDrive
- Branch
- arcpatch-D22462
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 14072 Build 14090: arc lint + arc unit
Comment Actions
The change around runJob() looks good, but all the changes in logging should go in separately since they are unrelated to the main part of the change.
src/kaccountsmanager.cpp | ||
---|---|---|
177 ↗ | (On Diff #61763) | Looks like a rather unrelated change, it should go in in a separate review (and commit). The refreshToken should get truncated as well, I think. |
src/kio_gdrive.cpp | ||
---|---|---|
473 | Please move this comment in the runJob() doxygen comment in kio_gdrive.h, rather than duplicating it here n times. |
src/kio_gdrive.cpp | ||
---|---|---|
148 | This message is a bit cryptic. How about "fileSystemFreeSpace is not supported for gdrive root urls?" |