Differential D22511

Minimap: Do not grab left mouse click over up/down arrows
ClosedPublic
Actions

Authored by sars on Jul 17 2019, 3:12 PM.

Details

Reviewers
brauch
Commits
R39:2d941799251c: Minimap: Do not grab the left-mmouse-button-click on up/down buttons
Summary

The arrow buttons stopped working when we implemented "jump to position" in minimap mode. This patch excludes the scroll-bar-arrow buttons from the press-event override.

Test Plan

The up/down buttons on the minimap-scrollbar work as expected.

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sars created this revision.Jul 17 2019, 3:12 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptJul 17 2019, 3:12 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
sars requested review of this revision.Jul 17 2019, 3:12 PM
brauch accepted this revision.Jul 17 2019, 3:16 PM

LGTM, thank you!

This revision is now accepted and ready to land.Jul 17 2019, 3:16 PM
Closed by commit R39:2d941799251c: Minimap: Do not grab the left-mmouse-button-click on up/down buttons (authored by sars). · Explain WhyJul 17 2019, 4:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/view/kateviewhelpers.cpp (5 lines)

Diff 61923

View Options

src/view/kateviewhelpers.cpp

Loading...