Get rid of some deprecated methods
ClosedPublic

Authored by yurchor on Jul 17 2019, 9:42 AM.

Details

Summary

Some methods in the current code are deprecated. Namely,

QPalette::foreground()
qStableSort()
qLowerBound()
QPixmapCache::find(const QString &key, QPixmap &pixmap)
QSignalMapper
QDrag::start()

Test Plan
  1. Compile Krusader (no more warnings about those methods for Qt 5.13).
  2. Start Krusader. List view, synchronizer, sorting on the panel should work as before.

Diff Detail

Repository
R167 Krusader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14035
Build 14053: arc lint + arc unit
yurchor requested review of this revision.Jul 17 2019, 9:42 AM
yurchor created this revision.
yurchor updated this revision to Diff 61896.Jul 17 2019, 9:45 AM

One more QPixmapCache::find()

gengisdave accepted this revision as: gengisdave.Jul 18 2019, 2:40 PM
gengisdave added a subscriber: gengisdave.

Looking at Qt, all the new methods are present in version 5.9 so that no checks with preprocessor are needed.

Also, these new methods have the same code of the deprecated one, except QDrag::exec() , but I've found no problems.

This revision is now accepted and ready to land.Jul 18 2019, 2:40 PM
This revision was automatically updated to reflect the committed changes.