Differential D22481

Do not show play/pause button when no media is playing
AbandonedPublic
Actions

Authored by shubham on Jul 15 2019, 6:46 PM.

Details

Reviewers
broulik
ngraham
Group Reviewers
Plasma
VDG

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13983
Build 14001: arc lint + arc unit
shubham created this revision.Jul 15 2019, 6:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 15 2019, 6:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
shubham requested review of this revision.Jul 15 2019, 6:46 PM
shubham added reviewers: broulik, Plasma, VDG.Jul 15 2019, 6:47 PM
shubham added subscribers: Plasma, VDG.
ndavis added a subscriber: ndavis.Jul 15 2019, 7:03 PM

This is how the widget currently looks:

Without the controls or text, it would just be a box, which makes it impossible to know which widget it's supposed to be.

filipf added a subscriber: filipf.Jul 31 2019, 4:42 PM
In D22481#496040, @davidedmundson wrote:

Why?

Seconded, why does the plasmoid need to be empty? Note that other plasmoids also specify if some thing A is not available.

ngraham requested changes to this revision.Jul 31 2019, 11:06 PM
ngraham added a subscriber: ngraham.

-1 for all the previously given reasons.

This revision now requires changes to proceed.Jul 31 2019, 11:06 PM
shubham abandoned this revision.Aug 24 2019, 3:06 PM

Revision Contents
Changeset List

Diff 61821

View Options

lookandfeel/contents/lockscreen/MediaControls.qml

Loading...