Differential D22456

Show session name in the Delete Session confirmation dialog
ClosedPublic
Actions

Authored by mdlubakowski on Jul 14 2019, 5:04 PM.

Details

Reviewers
apol
Group Reviewers
KDevelop
Commits
R32:c133947b7726: Show session name in the Delete Session confirmation dialog
Summary

Updated the Delete Session confimation to include chosen session name. Revision D13444 has been abandoned so I finished it.
Related: BUG 393138

Diff Detail

Repository
R32 KDevelop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13959
Build 13977: arc lint + arc unit
mdlubakowski created this revision.Jul 14 2019, 5:04 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptJul 14 2019, 5:04 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
mdlubakowski requested review of this revision.Jul 14 2019, 5:04 PM
mdlubakowski retitled this revision from Show session name in the Delete Session confimration dialog to Show session name in the Delete Session confirmation dialog.Jul 14 2019, 5:07 PM
mdlubakowski added a reviewer: KDevelop.
apol added a subscriber: apol.Jul 15 2019, 1:15 AM

LGTM otherwise

kdevplatform/shell/sessioncontroller.cpp
607

Then it needs a header, no?

mdlubakowski updated this revision to Diff 61776.Jul 15 2019, 5:25 AM
  • Added missing header for column with session name
mdlubakowski marked an inline comment as done.Jul 15 2019, 7:19 AM
apol accepted this revision.Jul 15 2019, 6:41 PM

LGTM can you land it?

This revision is now accepted and ready to land.Jul 15 2019, 6:41 PM
mdlubakowski added a comment.Jul 15 2019, 7:33 PM
In D22456#496025, @apol wrote:

LGTM can you land it?

I don't think I can, since I don't have developer account. It would be great if you could do this.

apol closed this revision.Jul 16 2019, 11:49 AM

Revision Contents
Changeset List

Diff 61776

View Options

kdevplatform/shell/sessionchooserdialog.cpp

Loading...
View Options

kdevplatform/shell/sessioncontroller.cpp

Loading...