Add Unsplash POTD Provider
ClosedPublic

Authored by guoyunhe on Jul 12 2019, 7:08 PM.

Details

Summary

Add Unsplash Wallpaper as picture of the day provider. Unsplash provides high quality photos under public domain license.

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
guoyunhe created this revision.Jul 12 2019, 7:08 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 12 2019, 7:08 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
guoyunhe requested review of this revision.Jul 12 2019, 7:08 PM
guoyunhe edited the summary of this revision. (Show Details)Jul 12 2019, 7:09 PM
guoyunhe added a reviewer: Plasma.
filipf added a subscriber: filipf.Jul 12 2019, 7:16 PM

Unsplash has very good wallpapers; in my opinion this automatically becomes the most attractive POTD plugin.

Keep in mind though that when I tried to add Unsplash wallpapers to KDE in D18078 I was told I need to contact the authors and have them re-licence their work for us...

Hopefully this issue can be avoided here as it's not exactly the same situation. You have a big +1 from me for the idea.

Photos on Unsplash are under CC0 (public domain) now. So here shouldn't be copyright issues.

I do think it is good to show photographers' credits. But that will require changes to POTD class and wallpaper widget.

ngraham accepted this revision.Jul 12 2019, 8:46 PM
ngraham added a subscriber: ngraham.

Very nice. Works great and I don't see any problems with the code here. Let's try to avoid a ton of bikeshedding over the licenses since these are CC0 IMO.

This revision is now accepted and ready to land.Jul 12 2019, 8:46 PM
guoyunhe updated this revision to Diff 61678.Jul 12 2019, 9:15 PM

Fix Unix new line format

Closed by commit R114:e0b126692a87: Add Unsplash POTD Provider (authored by Guo Yunhe <i@guoyunhe.me>). · Explain WhyJul 12 2019, 9:15 PM
This revision was automatically updated to reflect the committed changes.
ognarb added a subscriber: ognarb.Jul 14 2019, 9:08 PM

Photos on Unsplash are under CC0 (public domain) now. So here shouldn't be copyright issues.

I do think it is good to show photographers' credits. But that will require changes to POTD class and wallpaper widget.

Where did you read that Unsplash images were CC0? The license is not CC0 and is in fact non-free. Or are the pictures fetched at https://unsplash.com/wallpaper/1065396/desktop-wallpapers licensed explicitly under CC0?

Photos on Unsplash are under CC0 (public domain) now. So here shouldn't be copyright issues.

I do think it is good to show photographers' credits. But that will require changes to POTD class and wallpaper widget.

Where did you read that Unsplash images were CC0? The license is not CC0 and is in fact non-free. Or are the pictures fetched at https://unsplash.com/wallpaper/1065396/desktop-wallpapers licensed explicitly under CC0?

It's free. It's CC0 with the addition of "This license does not include the right to compile photos from Unsplash to replicate a similar or competing service.".