don't use nullptr to stay compatible with !c++11 & qt4
ClosedPublic
Actions

Authored by sitter on Jul 10 2019, 2:04 PM.

Details

Reviewers

dvratil
• jriddell

Commits

Test Plan

Riddell shall test in production

Repository

R488 Phonon: GStreamer backend

Branch

4.9

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13819
Build 13837: arc lint + arc unit

sitter requested review of this revision.Jul 10 2019, 2:04 PM

sitter created this revision.

anthonyfieroni added inline comments.

gstreamer/x11renderer.cpp
59	I see `override` here, not the only place :)

also throw out the overrides

good point

This revision is now accepted and ready to land.Jul 11 2019, 4:08 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			gstreamer/x11renderer.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	61511	b862059		Jul 10 2019, 2:04 PM	★	★
Diff 2	61523	b862059	also throw out the overrides	Jul 10 2019, 4:00 PM	★	★
Diff 3	61608	b862059	R488:f1ac69f79a41a3a65ff509170d8c9444acca9928	Jul 11 2019, 4:21 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
62d8e2e2609b	c2b673293ad1	b862059636e3	Harald Sitter	don't use nullptr or override to stay compatible with !c++11 & qt4 (Show More…)	Jul 10 2019, 2:04 PM