Differential D22004

Increment iterator before any potential continue
ClosedPublic
Actions

Authored by broulik on Jun 22 2019, 3:47 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R120:a0d9fcfe6283: Increment iterator before any potential continue
R119:51d16037ee16: Increment iterator before any potential continue
Summary

Otherwise if none of the results are viable, we could end up in an infinite loop because we continue before we actually advance the iterator but also never reach the actionCount limit.

Test Plan

This can probably go to 5.12

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jun 22 2019, 3:47 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 22 2019, 3:47 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jun 22 2019, 3:47 PM
broulik retitled this revision from [Task Manager] Increase iterator before any potential continue to [Task Manager] Increment iterator before any potential continue.
hein accepted this revision.Jun 22 2019, 3:48 PM
This revision is now accepted and ready to land.Jun 22 2019, 3:48 PM
broulik updated this revision to Diff 60370.Jun 22 2019, 3:56 PM
broulik retitled this revision from [Task Manager] Increment iterator before any potential continue to Increment iterator before any potential continue.
hein added a comment.Jun 22 2019, 4:21 PM

I'm not super happy with hardcoding directory separators and schemas, judicious use of QUrl::fromLocalFile or QUrl::fromUserInput would probably be better to norm behavior.

Closed by commit R119:51d16037ee16: Increment iterator before any potential continue (authored by broulik). · Explain WhyJun 22 2019, 4:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 60376

View Options

applets/kicker/plugin/actionlist.cpp

Loading...
View Options

applets/taskmanager/plugin/backend.cpp

Loading...